-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 15 pull requests #80276
Rollup of 15 pull requests #80276
Commits on Nov 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0698922 - Browse repository at this point
Copy the full SHA 0698922View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bd770c - Browse repository at this point
Copy the full SHA 7bd770cView commit details
Commits on Nov 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for df2ef1d - Browse repository at this point
Copy the full SHA df2ef1dView commit details
Commits on Nov 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 90e6eeb - Browse repository at this point
Copy the full SHA 90e6eebView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed7b244 - Browse repository at this point
Copy the full SHA ed7b244View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a40b6d - Browse repository at this point
Copy the full SHA 7a40b6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 50b2ade - Browse repository at this point
Copy the full SHA 50b2adeView commit details
Commits on Nov 26, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3b8617b - Browse repository at this point
Copy the full SHA 3b8617bView commit details
Commits on Nov 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 2f35fb1 - Browse repository at this point
Copy the full SHA 2f35fb1View commit details
Commits on Nov 29, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 06ca6bb - Browse repository at this point
Copy the full SHA 06ca6bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1a50ff - Browse repository at this point
Copy the full SHA d1a50ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for c89d439 - Browse repository at this point
Copy the full SHA c89d439View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94ad5e1 - Browse repository at this point
Copy the full SHA 94ad5e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5687c16 - Browse repository at this point
Copy the full SHA 5687c16View commit details
Commits on Dec 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for be2c8f2 - Browse repository at this point
Copy the full SHA be2c8f2View commit details -
Co-authored-by: Mara Bos <m-ou.se@m-ou.se>
Configuration menu - View commit details
-
Copy full SHA for baa5e47 - Browse repository at this point
Copy the full SHA baa5e47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b37259 - Browse repository at this point
Copy the full SHA 8b37259View commit details
Commits on Dec 19, 2020
-
Remap instrument-coverage line numbers in doctests
This uses the `SourceMap::doctest_offset_line` method to re-map line numbers from doctests. Remapping columns is not yet done. Part of issue rust-lang#79417.
Configuration menu - View commit details
-
Copy full SHA for 830ceaa - Browse repository at this point
Copy the full SHA 830ceaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b6c175 - Browse repository at this point
Copy the full SHA 5b6c175View commit details -
Edit rustc_middle::lint::LintSource docs
Edit punctuation in doc comment for rustc_middle::lint::LintSource::CommandLine.
Configuration menu - View commit details
-
Copy full SHA for 52b717f - Browse repository at this point
Copy the full SHA 52b717fView commit details -
docs: Edit rustc_middle::ty::query::on_disk_cache
Expand abbreviations for "incremental compliation". Also added the word "to" to the description of CacheEncoder.
Configuration menu - View commit details
-
Copy full SHA for 4fffa74 - Browse repository at this point
Copy the full SHA 4fffa74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01d7f87 - Browse repository at this point
Copy the full SHA 01d7f87View commit details
Commits on Dec 20, 2020
-
Fix labels for 'Library Tracking Issue' template
Each label needs to be separated by a comma (see the ICE issue template for an example of correct usage).
Configuration menu - View commit details
-
Copy full SHA for c127530 - Browse repository at this point
Copy the full SHA c127530View commit details -
Configuration menu - View commit details
-
Copy full SHA for e614a72 - Browse repository at this point
Copy the full SHA e614a72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51d1806 - Browse repository at this point
Copy the full SHA 51d1806View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f8c8e4 - Browse repository at this point
Copy the full SHA 9f8c8e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9fa3fe - Browse repository at this point
Copy the full SHA f9fa3feView commit details -
Fix typo in rustc_middle::ty::inhabitedness::DefIdForest docs.
Configuration menu - View commit details
-
Copy full SHA for 32baf23 - Browse repository at this point
Copy the full SHA 32baf23View commit details -
Remove
I-prioritize
from Zulip topicIt doesn't add anything since every topic in `t-compiler/wg-prioritization/alerts` is about prioritization. And it makes it harder to see the issue title, which is what the topic is actually about.
Configuration menu - View commit details
-
Copy full SHA for dc58fc4 - Browse repository at this point
Copy the full SHA dc58fc4View commit details
Commits on Dec 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 087101e - Browse repository at this point
Copy the full SHA 087101eView commit details -
Implemented a compiler diagnostic for move async mistake
Ran the tidy check Following the diagnostic guide better Diagnostic generation is now relegated to its own function in the diagnostics module. Added tests Fixed the ui test
Configuration menu - View commit details
-
Copy full SHA for a272d62 - Browse repository at this point
Copy the full SHA a272d62View commit details -
Configuration menu - View commit details
-
Copy full SHA for dffa1e2 - Browse repository at this point
Copy the full SHA dffa1e2View commit details -
Rollup merge of rust-lang#78242 - Nadrieril:rename-overlapping_endpoi…
…nts-lint, r=varkor Rename `overlapping_patterns` lint As discussed in rust-lang#65477. I also tweaked a few things along the way. r? `@varkor` `@rustbot` modify labels: +A-exhaustiveness-checking
Configuration menu - View commit details
-
Copy full SHA for 6e5f5e1 - Browse repository at this point
Copy the full SHA 6e5f5e1View commit details -
Rollup merge of rust-lang#79261 - faern:deprecate-compare-and-swap, r…
…=Amanieu Deprecate atomic compare_and_swap method Finish implementing [RFC 1443](https://github.com/rust-lang/rfcs/blob/master/text/1443-extended-compare-and-swap.md) (rust-lang/rfcs#1443). It was decided to deprecate `compare_and_swap` [back in Rust 1.12 already](rust-lang#31767 (comment)). I can't find any info about that decision being reverted. My understanding is just that it has been forgotten. If there has been a decision on keeping `compare_and_swap` then it's hard to find, and even if this PR does not go through it can act as a place where people can find out about the decision being reverted. Atomic operations are hard to understand, very hard. And it does not help that there are multiple similar methods to do compare and swap with. They are so similar that for a reader it might be hard to understand the difference. This PR aims to make that simpler by finally deprecating `compare_and_swap` which is essentially just a more limited version of `compare_exchange`. The documentation is also updated (according to the RFC text) to explain the differences a bit better. Even if we decide to not deprecate `compare_and_swap`. I still think the documentation for the atomic operations should be improved to better describe their differences and similarities. And the documentation can be written nicer than the PR currently proposes, but I wanted to start somewhere. Most of it is just copied from the RFC. The documentation for `compare_exchange` and `compare_exchange_weak` indeed describe how they work! The problem is that they are more complex and harder to understand than `compare_and_swap`. So for someone who does not fully grasp this they might fall back to using `compare_and_swap`. Making the documentation outline the similarities and differences might build a bridge for people so they can cross over to the more powerful and sometimes more efficient operations. The conversions I do to avoid the `std` internal deprecation errors are very straight forward `compare_and_swap -> compare_exchange` changes where the orderings are just using the mapping in the new documentation. Only in one place did I use `compare_exchange_weak`. This can probably be improved further. But the goal here was not for those operations to be perfect. Just to not get worse and to allow the deprecation to happen.
Configuration menu - View commit details
-
Copy full SHA for aec379f - Browse repository at this point
Copy the full SHA aec379fView commit details -
Rollup merge of rust-lang#79451 - usbalbin:array_zip, r=m-ou-se
Added [T; N]::zip() This is my first PR to rust so I hope I have done everything right, or at least close :) --- This is PR adds the array method `[T; N]::zip()` which, in my mind, is a natural extension to rust-lang#75212. My implementation of `zip()` is mostly just a modified copy-paste of `map()`. Should I keep the comments? Also am I right in assuming there should be no way for the `for`-loop to panic, thus no need for the dropguard seen in the `map()`-function? The doc comment is in a similar way a slightly modified copy paste of [`Iterator::zip()`](https://doc.rust-lang.org/beta/std/iter/trait.Iterator.html#method.zip) `@jplatte` mentioned in [rust-lang#75490](rust-lang#75490 (comment)) `zip_with()`, > zip and zip_with seem like they would be useful :) is this something I should add (assuming there is interest for this PR at all :))
Configuration menu - View commit details
-
Copy full SHA for f9b9e5d - Browse repository at this point
Copy the full SHA f9b9e5dView commit details -
Rollup merge of rust-lang#79762 - Swatinem:remap-doctest-coverage, r=…
…Swatinem Remap instrument-coverage line numbers in doctests This uses the `SourceMap::doctest_offset_line` method to re-map line numbers from doctests. Remapping columns is not yet done, and rustdoc still does not output the correct filename when running doctests in a workspace. Part of rust-lang#79417 although I dont consider that fixed until both filenames and columns are mapped correctly. r? `@richkadel` I might jump on zulip the comming days. Still need to figure out how to properly write tests for this, and deal with other doctest issues in the meantime.
Configuration menu - View commit details
-
Copy full SHA for 341b76c - Browse repository at this point
Copy the full SHA 341b76cView commit details -
Rollup merge of rust-lang#80160 - diondokter:move_async_fix, r=davidtwco
Implemented a compiler diagnostic for move async mistake Fixes rust-lang#79694 First time contributing, so I hope I'm doing everything right. (If not, please correct me!) This code performs a check when a move capture clause is parsed. The check is to detect if the user has reversed the async move keywords and to provide a diagnostic with a suggestion to fix it. Checked code: ```rust fn main() { move async { }; } ``` Previous output: ```txt PS C:\Repos\move_async_test> cargo build Compiling move_async_test v0.1.0 (C:\Repos\move_async_test) error: expected one of `|` or `||`, found keyword `async` --> src\main.rs:2:10 | 2 | move async { }; | ^^^^^ expected one of `|` or `||` error: aborting due to previous error error: could not compile `move_async_test` ``` New output: ```txt PS C:\Repos\move_async_test> cargo +dev build Compiling move_async_test v0.1.0 (C:\Repos\move_async_test) error: the order of `move` and `async` is incorrect --> src\main.rs:2:13 | 2 | let _ = move async { }; | ^^^^^^^^^^ | help: try switching the order | 2 | let _ = async move { }; | ^^^^^^^^^^ error: aborting due to previous error error: could not compile `move_async_test` ``` Is there a file/module where these kind of things are tested? Would love some feedback 😄
Configuration menu - View commit details
-
Copy full SHA for 233aa15 - Browse repository at this point
Copy the full SHA 233aa15View commit details -
Rollup merge of rust-lang#80203 - pierwill:pierwill-rustcmiddle-lint,…
… r=oli-obk Edit rustc_middle::lint::LintSource docs Edit punctuation in doc comment for [rustc_middle::lint::LintSource::CommandLine](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/lint/enum.LintSource.html#variant.CommandLine).
Configuration menu - View commit details
-
Copy full SHA for b86a966 - Browse repository at this point
Copy the full SHA b86a966View commit details -
Rollup merge of rust-lang#80204 - pierwill:pierwill-rustcmiddle-ondis…
…k, r=varkor docs: Edit rustc_middle::ty::query::on_disk_cache Expand abbreviations for "incremental compliation". Also added the word "to" to the description of CacheEncoder.
Configuration menu - View commit details
-
Copy full SHA for d4133df - Browse repository at this point
Copy the full SHA d4133dfView commit details -
Rollup merge of rust-lang#80208 - bugadani:generics-of-alloc, r=matth…
…ewjasper Reserve necessary space for params in generics_of Always reserve space for the exact number of generic parameters we need in generics_of. As far as I can see, the default is 0/4 elements based on has_self, and the vector grows on after that.
Configuration menu - View commit details
-
Copy full SHA for 2063b6f - Browse repository at this point
Copy the full SHA 2063b6fView commit details -
Rollup merge of rust-lang#80219 - camelid:library_tracking_issue-labe…
…ls, r=m-ou-se Fix labels for 'Library Tracking Issue' template Each label needs to be separated by a comma (see the ICE issue template for an example of correct usage). r? `@m-ou-se`
Configuration menu - View commit details
-
Copy full SHA for dde9d69 - Browse repository at this point
Copy the full SHA dde9d69View commit details -
Rollup merge of rust-lang#80222 - GreenRecycleBin:daniel/fix-rustc-st…
…d-workspace-core-documentation, r=jyn514 Fix rustc-std-workspace-core documentation r? `@steveklabnik`
Configuration menu - View commit details
-
Copy full SHA for 945ebe7 - Browse repository at this point
Copy the full SHA 945ebe7View commit details -
Rollup merge of rust-lang#80223 - pierwill:patch-10, r=lcnr
docs: Fix outdated crate reference
Configuration menu - View commit details
-
Copy full SHA for 2925484 - Browse repository at this point
Copy the full SHA 2925484View commit details -
Rollup merge of rust-lang#80225 - pierwill:patch-11, r=lcnr
Add module-level docs to rustc_middle::ty I thought it would be nice to point out `Ty` and `TyCtxt` on the module page, and link out to the [rustc-dev-guide chapter](https://rustc-dev-guide.rust-lang.org/ty.html).
Configuration menu - View commit details
-
Copy full SHA for 1ae2913 - Browse repository at this point
Copy the full SHA 1ae2913View commit details -
Rollup merge of rust-lang#80241 - pierwill:patch-12, r=lcnr
Fix typo Fix typo in rustc_middle::ty::inhabitedness::DefIdForest docs.
Configuration menu - View commit details
-
Copy full SHA for 698e258 - Browse repository at this point
Copy the full SHA 698e258View commit details -
Rollup merge of rust-lang#80248 - camelid:prioritize-zulip-topic, r=M…
…ark-Simulacrum Remove `I-prioritize` from Zulip topic It doesn't add anything since every topic in `t-compiler/wg-prioritization/alerts` is about prioritization. And it makes it harder to see the issue title, which is what the topic is actually about. cc `@rust-lang/wg-prioritization`
Configuration menu - View commit details
-
Copy full SHA for d0e2518 - Browse repository at this point
Copy the full SHA d0e2518View commit details -
Rollup merge of rust-lang#80266 - bugadani:dup-test, r=jyn514
Remove redundant test Remove ignored test. This test can also be found at src/test/rustdoc-ui/intra-doc/double-anchor.rs and the second version isn't ignored. r? `@jyn514`
Configuration menu - View commit details
-
Copy full SHA for 02b2798 - Browse repository at this point
Copy the full SHA 02b2798View commit details