Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "De-share ast::Ty" #8072

Closed
wants to merge 1 commit into from
Closed

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Jul 27, 2013

This reverts commit 47eca21.

Rebased from @Aatch's previous PR #7644, attempting to land.

@emberian
Copy link
Member

emberian commented Aug 8, 2013

@graydon @Aatch any resolution on this?

@graydon
Copy link
Contributor Author

graydon commented Aug 14, 2013

None yet. Really bad scene. It needs to be done.

@graydon
Copy link
Contributor Author

graydon commented Aug 16, 2013

Closing for now. Will reopen when it's ready to try again.

@graydon graydon closed this Aug 16, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Dec 6, 2021
…r=llogiq

Enable rustbot shortcuts for rust-clippy

This enables shortcuts for ``@rustbot`.` Just a quality of life feature for contributors.

|Shortcut| Full comment |
|---|---|
| ``@rustbot` ready` | ``@rustbot` label -S-waiting-on-author +S-waiting-on-review` |
| ``@rustbot` author` | ``@rustbot` label +S-waiting-on-author -S-waiting-on-review` |

See: https://github.com/rust-lang/triagebot/wiki/Shortcuts

The documentation also states that the author/assignee will be pinged. However, this doesn't seem to be the case, it at least hasn't done so for me and in this [PR](rust-lang#90642 (comment))

---

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants