-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 14 pull requests #81355
Rollup of 14 pull requests #81355
Commits on Aug 5, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 39466bc - Browse repository at this point
Copy the full SHA 39466bcView commit details
Commits on Oct 31, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 573ec31 - Browse repository at this point
Copy the full SHA 573ec31View commit details
Commits on Nov 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 517d462 - Browse repository at this point
Copy the full SHA 517d462View commit details
Commits on Dec 11, 2020
-
Replace magic numbers with existing constants
Split long lines over 100 char line limit Fix tidy complaints
Configuration menu - View commit details
-
Copy full SHA for c387e29 - Browse repository at this point
Copy the full SHA c387e29View commit details
Commits on Dec 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for bbf5001 - Browse repository at this point
Copy the full SHA bbf5001View commit details
Commits on Jan 9, 2021
-
Expand assert!(expr, args..) to include $crate for hygiene on 2021.
Before 2021, this was a breaking change, as std::panic and core::panic are different. In edition 2021 they will be identical, making it possible again to apply proper hygiene here.
Configuration menu - View commit details
-
Copy full SHA for a1c41e9 - Browse repository at this point
Copy the full SHA a1c41e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8098ac1 - Browse repository at this point
Copy the full SHA 8098ac1View commit details
Commits on Jan 20, 2021
-
Fix sysroot option not being honored across rustc
Change link_sanitizer_runtime() to check if the sanitizer library exists in the specified/session sysroot, and if it doesn't exist, use the default sysroot.
Configuration menu - View commit details
-
Copy full SHA for 7378676 - Browse repository at this point
Copy the full SHA 7378676View commit details
Commits on Jan 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3e9f27d - Browse repository at this point
Copy the full SHA 3e9f27dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 58a90de - Browse repository at this point
Copy the full SHA 58a90deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9988821 - Browse repository at this point
Copy the full SHA 9988821View commit details -
Configuration menu - View commit details
-
Copy full SHA for d63b278 - Browse repository at this point
Copy the full SHA d63b278View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee639de - Browse repository at this point
Copy the full SHA ee639deView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa4f583 - Browse repository at this point
Copy the full SHA aa4f583View commit details -
Configuration menu - View commit details
-
Copy full SHA for f29b329 - Browse repository at this point
Copy the full SHA f29b329View commit details
Commits on Jan 23, 2021
-
Do not mark unit variants as used when in path pattern
Record that we are processing a pattern so that code responsible for handling path resolution can correctly decide whether to mark it as used or not.
Configuration menu - View commit details
-
Copy full SHA for 99a1dea - Browse repository at this point
Copy the full SHA 99a1deaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 794880c - Browse repository at this point
Copy the full SHA 794880cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d118021 - Browse repository at this point
Copy the full SHA d118021View commit details -
Configuration menu - View commit details
-
Copy full SHA for b217fab - Browse repository at this point
Copy the full SHA b217fabView commit details -
Fix a comment that only made sense in the context of a dataflow based…
… mutability check
Configuration menu - View commit details
-
Copy full SHA for 3cd0b46 - Browse repository at this point
Copy the full SHA 3cd0b46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00e62fa - Browse repository at this point
Copy the full SHA 00e62faView commit details -
Do not allow arbitrary mutable references in
static mut
, just keep ……with the existing exceptions
Configuration menu - View commit details
-
Copy full SHA for 14f39aa - Browse repository at this point
Copy the full SHA 14f39aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd09871 - Browse repository at this point
Copy the full SHA cd09871View commit details -
Configuration menu - View commit details
-
Copy full SHA for 819b008 - Browse repository at this point
Copy the full SHA 819b008View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1129e86 - Browse repository at this point
Copy the full SHA 1129e86View commit details -
Add option to control doctest run directory
This option will allow splitting the compile-time from the run-time directory of doctest invocations and is one step to solve rust-lang/cargo#8993 (comment)
Configuration menu - View commit details
-
Copy full SHA for 9b1d27d - Browse repository at this point
Copy the full SHA 9b1d27dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 20a460e - Browse repository at this point
Copy the full SHA 20a460eView commit details
Commits on Jan 24, 2021
-
Replace version_check dependency with own version parsing code
This gives compiler maintainers a better degree of control over how the version gets parsed and is a good way to ensure that there are no changes of behaviour in the future. Also, issue a warning if the version is invalid instead of erroring so that we stay forwards compatible with possible future changes of the versioning scheme. Last, this improves the present test a little.
Configuration menu - View commit details
-
Copy full SHA for 14aa12f - Browse repository at this point
Copy the full SHA 14aa12fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 351b2ac - Browse repository at this point
Copy the full SHA 351b2acView commit details -
Configuration menu - View commit details
-
Copy full SHA for c37c421 - Browse repository at this point
Copy the full SHA c37c421View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8416fa - Browse repository at this point
Copy the full SHA f8416faView commit details -
Configuration menu - View commit details
-
Copy full SHA for a730970 - Browse repository at this point
Copy the full SHA a730970View commit details -
Rollup merge of #75180 - KodrAus:feat/error-by-ref, r=m-ou-se
Implement Error for &(impl Error) Opening this up just to see what it breaks. It's unfortunate that `&(impl Error)` doesn't actually implement `Error`. If this direct approach doesn't work out then I'll try something different, like an `Error::by_ref` method. **EDIT:** This is a super low-priority experiment so feel free to cancel it for more important crater runs! 🙂 ----- # Stabilization Report ## Why? We've been working for the last few years to try "fix" the `Error` trait, which is probably one of the most fundamental in the whole standard library. One of its issues is that we commonly expect you to work with abstract errors through `dyn Trait`, but references and smart pointers over `dyn Trait` don't actually implement the `Error` trait. If you have a `&dyn Error` or a `Box<dyn Error>` you simply can't pass it to a method that wants a `impl Error`. ## What does this do? This stabilizes the following trait impl: ```rust impl<'a, T: Error + ?Sized + 'static> Error for &'a T; ``` This means that `&dyn Error` will now satisfy a `impl Error` bound. It doesn't do anything with `Box<dyn Error>` directly. We discussed how we could do `Box<dyn Error>` in the thread here (and elsewhere in the past), but it seems like we need something like lattice-based specialization or a sprinkling of snowflake compiler magic to make that work. Having said that, with this new impl you _can_ now get a `impl Error` from a `Box<dyn Error>` by dereferencing it. ## What breaks? A crater run revealed a few crates broke with something like the following: ```rust // where e: &'short &'long dyn Error err.source() ``` previously we'd auto-deref that `&'short &'long dyn Error` to return a `Option<&'long dyn Error>` from `source`, but now will call directly on `&'short impl Error`, so will return a `Option<&'short dyn Error>`. The fix is to manually deref: ```rust // where e: &'short &'long dyn Error (*err).source() ``` In the recent Libs meeting we considered this acceptable breakage.
Configuration menu - View commit details
-
Copy full SHA for 5a1f2ec - Browse repository at this point
Copy the full SHA 5a1f2ecView commit details -
Rollup merge of #78578 - oli-obk:const_mut_refs, r=RalfJung
Permit mutable references in all const contexts fixes #71212 cc `@rust-lang/wg-const-eval` `@christianpoveda`
Configuration menu - View commit details
-
Copy full SHA for d9c177f - Browse repository at this point
Copy the full SHA d9c177fView commit details -
Rollup merge of #79174 - taiki-e:std-future, r=Mark-Simulacrum
Configuration menu - View commit details
-
Copy full SHA for 13b88c2 - Browse repository at this point
Copy the full SHA 13b88c2View commit details -
Rollup merge of #79884 - Digital-Chaos:replace-magic, r=m-ou-se
Replace magic numbers with existing constants Replaced magic numbers in `library/core/src/time.rs` with predefined constants.
Configuration menu - View commit details
-
Copy full SHA for 3ed8a37 - Browse repository at this point
Copy the full SHA 3ed8a37View commit details -
Rollup merge of #80855 - m-ou-se:assert-2021, r=petrochenkov
Expand assert!(expr, args..) to include $crate for hygiene on 2021. This makes `assert!(expr, args..)` properly hygienic in Rust 2021. This is part of rust-lang/rfcs#3007, see #80162. Before edition 2021, this was a breaking change, as `std::panic` and `core::panic` are different. In edition 2021 they will be identical, making it possible to apply proper hygiene here.
Configuration menu - View commit details
-
Copy full SHA for e8ef15d - Browse repository at this point
Copy the full SHA e8ef15dView commit details -
Rollup merge of #80933 - rcvalle:fix-sysroot-option, r=nagisa
Fix sysroot option not being honored across rustc Change link_sanitizer_runtime() to check if the sanitizer library exists in the specified/session sysroot, and if it doesn't exist, use the default sysroot. (See #79253.)
Configuration menu - View commit details
-
Copy full SHA for 27abbc2 - Browse repository at this point
Copy the full SHA 27abbc2View commit details -
Rollup merge of #81259 - est31:cfg_version, r=petrochenkov
Replace version_check dependency with own version parsing code This gives compiler maintainers a better degree of control over how the version gets parsed and is a good way to ensure that there are no changes of behaviour in the future. Also, issue a warning if the version is invalid instead of erroring so that we stay forwards compatible with possible future changes of the versioning scheme. Last, this improves the present test a little. Fixes #79436 r? `@petrochenkov`
Configuration menu - View commit details
-
Copy full SHA for 22dc82f - Browse repository at this point
Copy the full SHA 22dc82fView commit details -
Rollup merge of #81264 - Swatinem:doctest-run-directory, r=jyn514
Add unstable option to control doctest run directory This option will allow splitting the compile-time from the run-time directory of doctest invocations and is one step to solve rust-lang/cargo#8993 (comment) r? `@jyn514`
Configuration menu - View commit details
-
Copy full SHA for 504d6de - Browse repository at this point
Copy the full SHA 504d6deView commit details -
Rollup merge of #81279 - bugadani:iter, r=davidtwco
Small refactor in typeck - `check_impl_items_against_trait` only queries and walks through associated items once - extracted function that reports errors - don't check specialization validity when trait item does not match - small additional cleanups
Configuration menu - View commit details
-
Copy full SHA for 70be327 - Browse repository at this point
Copy the full SHA 70be327View commit details -
Rollup merge of #81297 - bjorn3:no_extern_backend_optimization_level_…
…query_provider, r=cjgillot Don't provide backend_optimization_level query for extern crates Fixes #71291
Configuration menu - View commit details
-
Copy full SHA for 9089dd2 - Browse repository at this point
Copy the full SHA 9089dd2View commit details -
Rollup merge of #81302 - LeSeulArtichaut:80777-trait-render, r=jyn514
Fix rendering of stabilization version for trait implementors Rustdoc compares an item's stabilization version with its parent's to not render it if they are the same. Here, the implementor was compared with itself, resulting in the stabilization version never getting shown. This probably needs a test. Fixes #80777. r? `@jyn514`
Configuration menu - View commit details
-
Copy full SHA for ee4461a - Browse repository at this point
Copy the full SHA ee4461aView commit details -
Rollup merge of #81310 - tmiasko:in-pattern, r=petrochenkov
Do not mark unit variants as used when in path pattern Record that we are processing a pattern so that code responsible for handling path resolution can correctly decide whether to mark it as used or not. Closes #76788.
Configuration menu - View commit details
-
Copy full SHA for 04ddf42 - Browse repository at this point
Copy the full SHA 04ddf42View commit details -
Rollup merge of #81320 - CraftSpider:jsondoc-errors, r=jyn514
Make bad shlex parsing a pretty error Closes #81319 Old Output: <details><summary>Backtrace</summary> <p> ``` thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src\too ls\jsondocck\src\main.rs:152:81 stack backtrace: 0: 0x7ff79a011405 - std::backtrace_rs::backtrace::dbghelp::trace at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\/library\std\src\..\..\backtrace\src\backtrace\dbghelp.rs:98 1: 0x7ff79a011405 - std::backtrace_rs::backtrace::trace_unsynchronized at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\/library\std\src\..\..\backtrace\src\backtrace\mod.rs:66 2: 0x7ff79a011405 - std::sys_common::backtrace::_print_fmt at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\/library\std\src\sys_common\backtrace.rs:67 3: 0x7ff79a011405 - std::sys_common::backtrace::_print::{{impl}}::fmt at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\/library\std\src\sys_common\backtrace.rs:46 4: 0x7ff79a026c7b - core::fmt::write at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\/library\core\src\fmt\mod.rs:1078 5: 0x7ff79a00e74d - std::io::Write::write_fmt<std::sys::windows::stdio::S tderr> at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\/library\std\src\io\mod.rs:1519 6: 0x7ff79a01413d - std::sys_common::backtrace::_print at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\/library\std\src\sys_common\backtrace.rs:49 7: 0x7ff79a01413d - std::sys_common::backtrace::print at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\/library\std\src\sys_common\backtrace.rs:36 8: 0x7ff79a01413d - std::panicking::default_hook::{{closure}} at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\/library\std\src\panicking.rs:208 9: 0x7ff79a013c4a - std::panicking::default_hook at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\/library\std\src\panicking.rs:225 10: 0x7ff79a014a7e - std::panicking::rust_panic_with_hook at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\/library\std\src\panicking.rs:591 11: 0x7ff79a014573 - std::panicking::begin_panic_handler::{{closure}} at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\/library\std\src\panicking.rs:495 12: 0x7ff79a011ddf - std::sys_common::backtrace::__rust_end_short_backtrac e<closure-0,!> at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\/library\std\src\sys_common\backtrace.rs:141 13: 0x7ff79a0144f9 - std::panicking::begin_panic_handler at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\/library\std\src\panicking.rs:493 14: 0x7ff79a025230 - core::panicking::panic_fmt at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\/library\core\src\panicking.rs:92 15: 0x7ff79a02517c - core::panicking::panic at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\/library\core\src\panicking.rs:50 16: 0x7ff799f5245f - indexmap::map::core::raw::<impl indexmap::map::core:: IndexMapCore<K,V>>::get_index_of::had34e726f99bd999 17: 0x7ff799f48fea - std::sys_common::backtrace::__rust_begin_short_backtr ace::h1ac92efa44350e74 18: 0x7ff799f41015 - std::rt::lang_start::{{closure}}::hdfe733a6a1ad9a18 19: 0x7ff79a014c34 - core::ops::function::impls::{{impl}}::call_once at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\library\core\src\ops\function.rs:280 20: 0x7ff79a014c34 - std::panicking::try::do_call at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\/library\std\src\panicking.rs:379 21: 0x7ff79a014c34 - std::panicking::try at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\/library\std\src\panicking.rs:343 22: 0x7ff79a014c34 - std::panic::catch_unwind at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\/library\std\src\panic.rs:396 23: 0x7ff79a014c34 - std::rt::lang_start_internal at /rustc/05b6023675d77979637b04a350c85903fbf5925 7\/library\std\src\rt.rs:51 24: 0x7ff799f536a7 - main 25: 0x7ff79a02d788 - invoke_main at d:\A01\_work\6\s\src\vctools\crt\vcstartup\src \startup\exe_common.inl:78 26: 0x7ff79a02d788 - __scrt_common_main_seh at d:\A01\_work\6\s\src\vctools\crt\vcstartup\src \startup\exe_common.inl:288 27: 0x7ffe6bf47034 - BaseThreadInitThunk 28: 0x7ffe6c89d241 - RtlUserThreadStart ``` </p> </details> New Output: ``` Invalid command: Invalid arguments to shlex::split: ` - "$foo` on line 26 ``` I've hit this a couple times, makes debugging a little nicer.
Configuration menu - View commit details
-
Copy full SHA for 558b878 - Browse repository at this point
Copy the full SHA 558b878View commit details -
Rollup merge of #81338 - bugadani:dominator-cleanup, r=davidtwco
Clean up `dominators_given_rpo`
Configuration menu - View commit details
-
Copy full SHA for 529f15f - Browse repository at this point
Copy the full SHA 529f15fView commit details