Code

Rollup of 16 pull requests#81998

Code

Closed

jonas-schievink wants to merge 135 commits intorust-lang:masterrust-lang/rust:masterfrom jonas-schievink:rollup-ckz22goCopy head branch name to clipboard

+2,140-731

Commits

Commits on Dec 12, 2020

• fix indefinite article in cell.rs

  petar-dambovaliev

  authored
  2b9ba46

  Copy full SHA for 2b9ba46

Commits on Feb 1, 2021

• Add unit tests for new lint

  nahuakang

  committed
  949b125

  Copy full SHA for 949b125

• Draft skeleton for new lint

  nahuakang

  committed
  5753614

  Copy full SHA for 5753614

• Rename lint

  nahuakang

  committed
  3da25ed

  Copy full SHA for 3da25ed

• Run cargo dev update_lints

  nahuakang

  committed
  8973f2c

  Copy full SHA for 8973f2c

• Implement manual flatten lint

  nahuakang

  committed
  b87e189

  Copy full SHA for b87e189

• Fix suggestions that need parens

  ThibsG

  committed
  7825bf3

  Copy full SHA for 7825bf3

Commits on Feb 2, 2021

• Enhance manual flatten

  nahuakang

  committed
  e07cd5b

  Copy full SHA for e07cd5b

Commits on Feb 3, 2021

• Merge commit '3e4179766bcecd712824da04356621b8df012ea4' into sync-from-clippy

  Manishearth

  committed
  c8cb90a

  Copy full SHA for c8cb90a

• Add additional check on if arg type has iter method

  nahuakang

  committed
  0f5e71f

  Copy full SHA for 0f5e71f

• Use PrimTy in builtin type shadow lint

  camsteffen

  committed
  f2e82af

  Copy full SHA for f2e82af

• Fix file names of flat_map_identity test

  Show description for 6396b8f
  magurotuna

  committed
  6396b8f

  Copy full SHA for 6396b8f

• Auto merge of #6669 - magurotuna:fix-test-name, r=flip1995

  Show description for 876ffa4
  bors

  committed
  876ffa4

  Copy full SHA for 876ffa4

• Add additional test cases and improve span lint

  nahuakang

  committed
  78ef0f2

  Copy full SHA for 78ef0f2

• Fix/allow non_fmt_panic in clippy tests.

  m-ou-se

  committed
  0767a0f

  Copy full SHA for 0767a0f

• Suggest panic!("{}", ..) instead of panic!(..) clippy::expect_fun_call.

  m-ou-se

  committed
  9f7f8b7

  Copy full SHA for 9f7f8b7

Commits on Feb 4, 2021

• Increment self.index before calling Iterator::self.a.__iterator_get_unchecked in Zip TrustedRandomAccess specialization

  Show description for 86a4b27
  sdroege

  committed
  86a4b27

  Copy full SHA for 86a4b27

• Improve lint message; add note for future autofixable updates

  nahuakang

  committed
  2f8a8d3

  Copy full SHA for 2f8a8d3

• Auto merge of #6646 - nahuakang:for_loops_over_options_or_results, r=flip1995

  Show description for 357c6a7
  bors

  committed
  357c6a7

  Copy full SHA for 357c6a7

• Set turbofish for every sugg and add more test cases

  ThibsG

  committed
  233fe11

  Copy full SHA for 233fe11

• Support free functions in disallowed-methods lint

  Show description for 7b7e3ca
  phlip9

  committed
  7b7e3ca

  Copy full SHA for 7b7e3ca

Commits on Feb 5, 2021

• fix typo

  TaKO8Ki

  committed
  67d48e1

  Copy full SHA for 67d48e1

• Use absolute path to Rust repo in ra_setup

  Show description for 79dbf10
  flip1995

  committed
  79dbf10

  Copy full SHA for 79dbf10

• Cleanup path to local checks

  camsteffen

  committed
  56f7fbb

  Copy full SHA for 56f7fbb

• Auto merge of #6678 - TaKO8Ki:fix-typo, r=flip1995

  Show description for 89f266a
  bors

  committed
  89f266a

  Copy full SHA for 89f266a

• Auto merge of #6679 - flip1995:ra_setup_abs_path, r=Manishearth

  Show description for a507c27
  bors

  committed
  a507c27

  Copy full SHA for a507c27

• First version of the lint

  1c3t3a

  committed
  eb9c669

  Copy full SHA for eb9c669

• Added documentation

  1c3t3a

  committed
  f907986

  Copy full SHA for f907986

• Fixed macro edge case for semicolon_if_nothing_returned lint

  1c3t3a

  committed
  55bfaa1

  Copy full SHA for 55bfaa1

• Fix let_underscore_drop implements Drop logic

  Show description for ac5e9c8
  camsteffen

  committed
  ac5e9c8

  Copy full SHA for ac5e9c8

• Bump clippy version

  Mark-Simulacrum

  committed
  a9ad492

  Copy full SHA for a9ad492

• tests: ignore check_that_clippy_has_the_same_major_version_as_rustc() inside the rustc repo.

  Show description for 93daf27
  matthiaskrgr

  committed
  93daf27

  Copy full SHA for 93daf27

Commits on Feb 6, 2021

• Add new lint filter_map_identity

  Show description for a60c143
  magurotuna

  committed
  a60c143

  Copy full SHA for a60c143

• Use flatten instead of filter_map

  magurotuna

  committed
  fbe436b

  Copy full SHA for fbe436b

• lintcheck: update logs

  matthiaskrgr

  committed
  cb30219

  Copy full SHA for cb30219

• lintcheck: make TomlCrate also accept git-data from lintcheck_crates.toml

  matthiaskrgr

  committed
  64982cc

  Copy full SHA for 64982cc

• implement the download_and_extract() step for git sources

  matthiaskrgr

  committed
  10fbafa

  Copy full SHA for 10fbafa

• lintcheck: add git source as an example and update logs

  matthiaskrgr

  committed
  9ab505a

  Copy full SHA for 9ab505a

• lintcheck: cleanup, fix --only for git crates, better error msgs

  matthiaskrgr

  committed
  e1c284b

  Copy full SHA for e1c284b

• Fixed for loop problem, corrected all occurences that got linted

  1c3t3a

  committed
  6626295

  Copy full SHA for 6626295

• Auto merge of #6684 - matthiaskrgr:versiontest_dont_break_upstream, r=flip1995

  Show description for dfb34c0
  bors

  committed
  dfb34c0

  Copy full SHA for dfb34c0

• Revert "Fixed for loop problem, corrected all occurences that got linted"

  Show description for cd67487
  1c3t3a

  committed
  cd67487

  Copy full SHA for cd67487

• Switched to snippet_with_macro_callsite

  1c3t3a

  committed
  85c2b1e

  Copy full SHA for 85c2b1e

• Rollup merge of #81680 - camsteffen:primty, r=oli-obk

  Show description for a5d442c
  jonas-schievink

  authored
  a5d442c

  Copy full SHA for a5d442c

• Changed lint level to restriction

  1c3t3a

  committed
  f1c1584

  Copy full SHA for f1c1584

• Fix cargo_common_metadata warning on publish = false.

  daxpedda

  committed
  915e9b8

  Copy full SHA for 915e9b8

• Test names were flipped.

  daxpedda

  committed
  d4bc7d2

  Copy full SHA for d4bc7d2

• Implement _cargo_ignore_publish.

  daxpedda

  committed
  f0d3fd7

  Copy full SHA for f0d3fd7

• Hide clippy configuration option.

  Show description for 8805931
  

  daxpedda

  and

  flip1995

  committed
  8805931

  Copy full SHA for 8805931

• Change clippy configuration option.

  daxpedda

  committed
  f2391a5

  Copy full SHA for f2391a5

• Add test for publish = true.

  daxpedda

  committed
  8b89087

  Copy full SHA for 8b89087

• Add back publish = false to the old test.

  daxpedda

  committed
  cd361a5

  Copy full SHA for cd361a5

• Pick up clippy.toml in ui-cargo tests.

  daxpedda

  committed
  e2e33b4

  Copy full SHA for e2e33b4

• Fux toml_unknown_key test.

  daxpedda

  committed
  3c8f754

  Copy full SHA for 3c8f754

• Document condition.

  daxpedda

  committed
  ea0b832

  Copy full SHA for ea0b832

• Confused about my own explanation.

  daxpedda

  committed
  fd8b5fa

  Copy full SHA for fd8b5fa

• lintcheck: avoid dbg!() calls

  matthiaskrgr

  committed
  2bffbfc

  Copy full SHA for 2bffbfc

• Stabilize workspace wrapper.

  ehuss

  committed
  0585c34

  Copy full SHA for 0585c34

• Fixed suggestion in macro invocations

  1c3t3a

  committed
  6b4789d

  Copy full SHA for 6b4789d

• Eat dogfood

  camsteffen

  committed
  40ce056

  Copy full SHA for 40ce056

• Update triagebot.toml to new label names

  flip1995

  authored
  dfe08f4

  Copy full SHA for dfe08f4

Commits on Feb 7, 2021

• use rwlock for accessing ENV

  the8472

  committed
  55ca27f

  Copy full SHA for 55ca27f

• Auto merge of #6682 - camsteffen:let-underscore-ref, r=llogiq

  Show description for d792210
  bors

  committed
  d792210

  Copy full SHA for d792210

• Auto merge of #6688 - rust-lang:triagebot_update, r=phansch

  Show description for b36d1a4
  bors

  committed
  b36d1a4

  Copy full SHA for b36d1a4

• Auto merge of #6660 - camsteffen:path-to-local, r=llogiq

  Show description for d51db24
  bors

  committed
  d51db24

  Copy full SHA for d51db24

• silence dead code warnings on windows

  the8472

  committed
  406fd3a

  Copy full SHA for 406fd3a

• Auto merge of #6681 - 1c3t3a:1c3t3a-issue-6467, r=xFrednet,flip1995,phansch

  Show description for 001185d
  bors

  committed
  001185d

  Copy full SHA for 001185d

• Auto merge of #6685 - magurotuna:filter_map_identity, r=phansch

  Show description for ad9ceee
  bors

  committed
  ad9ceee

  Copy full SHA for ad9ceee

• Auto merge of #6674 - phlip9:disallowed_functions, r=llogiq

  Show description for 83b7b16
  bors

  committed
  83b7b16

  Copy full SHA for 83b7b16

• Auto merge of #6686 - matthiaskrgr:lintcheck_git, r=flip1995

  Show description for c1ce78f
  bors

  committed
  c1ce78f

  Copy full SHA for c1ce78f

• lintcheck: add a cmdline option --crates-toml <TOML PATH> to override crate sources file to use.

  Show description for 6f3eeac
  matthiaskrgr

  committed
  6f3eeac

  Copy full SHA for 6f3eeac

• add a new lint bytes_nth

  TaKO8Ki

  committed
  1c3033d

  Copy full SHA for 1c3033d

• Auto merge of #6694 - matthiaskrgr:lintcheck-cfg, r=Manishearth

  Show description for de35c29
  bors

  committed
  de35c29

  Copy full SHA for de35c29

Commits on Feb 8, 2021

• Downgrade trivial_regex to nursery

  dtolnay

  committed
  fd35517

  Copy full SHA for fd35517

• Auto merge of #6696 - dtolnay-contrib:regex, r=Manishearth

  Show description for 4bbd7e4
  bors

  committed
  4bbd7e4

  Copy full SHA for 4bbd7e4

• Enhance LocalUsedVisitor to check closure bodies

  camsteffen

  committed
  1d30422

  Copy full SHA for 1d30422

• Refactor out UnusedSelfVisitor

  camsteffen

  committed
  5db48a3

  Copy full SHA for 5db48a3

• Use path_to_local_id

  camsteffen

  committed
  37555f8

  Copy full SHA for 37555f8

• avoid &mut on the read path since it now allows concurrent readers

  the8472

  committed
  2200cf1

  Copy full SHA for 2200cf1

• introduce StaticRWLock wrapper to make methods safe

  the8472

  committed
  44abad5

  Copy full SHA for 44abad5

Commits on Feb 9, 2021

• Rename HIR UnOp variants

  Show description for 34b373d
  osa1

  committed
  34b373d

  Copy full SHA for 34b373d

• Rename "good first issue" back to "good-first-issue"

  flip1995

  authored
  775ce47

  Copy full SHA for 775ce47

• Auto merge of #6704 - rust-lang:flip1995-patch-1, r=phansch

  Show description for 03a0dd5
  bors

  committed
  03a0dd5

  Copy full SHA for 03a0dd5

• Add better turbofish extractor

  ThibsG

  committed
  b932587

  Copy full SHA for b932587

• Remove rustfmt from rust-toolchain file

  Show description for 03737e2
  flip1995

  authored
  03737e2

  Copy full SHA for 03737e2

• Auto merge of #6709 - rust-lang:flip1995-patch-1, r=matthiaskrgr

  Show description for 08b4d50
  bors

  committed
  08b4d50

  Copy full SHA for 08b4d50

• split guard into read and write types

  the8472

  committed
  4fc181d

  Copy full SHA for 4fc181d

Commits on Feb 10, 2021

• Use ItemCtxt::to_ty

  camsteffen

  committed
  471ed5f

  Copy full SHA for 471ed5f

• RELEASES.md 1.50: Group platform support notes together

  Show description for 883988b
  joshtriplett

  committed
  883988b

  Copy full SHA for 883988b

• bootstrap: Locate llvm-dwp based on llvm-config bindir

  dtolnay

  committed
  d3fea13

  Copy full SHA for d3fea13

• Auto merge of #6698 - camsteffen:path-to-local, r=phansch

  Show description for 0e371b8
  bors

  committed
  0e371b8

  Copy full SHA for 0e371b8

• Update clippy_lints/src/methods/bytes_nth.rs

  Show description for 932cc08
  

  TaKO8Ki

  and

  phansch

  authored
  932cc08

  Copy full SHA for 932cc08

• add some test cases

  TaKO8Ki

  committed
  5996ae1

  Copy full SHA for 5996ae1

• Fix assosiated typo

  Show description for a6d4137
  therealprof

  committed
  a6d4137

  Copy full SHA for a6d4137

• Allow casting mut array ref to mut ptr

  Show description for d64b749
  osa1

  committed
  d64b749

  Copy full SHA for d64b749

• Auto merge of #6687 - ehuss:stabilize-wrapper, r=flip1995

  Show description for 9c0ae2a
  bors

  committed
  9c0ae2a

  Copy full SHA for 9c0ae2a

• Catch errors on localStorage setting failure

  Show description for f13bbea
  lovasoa

  authored
  f13bbea

  Copy full SHA for f13bbea

• Auto merge of #6695 - TaKO8Ki:add-bytes-nth, r=phansch

  Show description for b5e4389
  bors

  committed
  b5e4389

  Copy full SHA for b5e4389

• Fix getCurrentValue

  lovasoa

  authored
  16f0ccd

  Copy full SHA for 16f0ccd

• Fix typo

  alpaca-tc

  committed
  94b8f23

  Copy full SHA for 94b8f23

• Auto merge of #6714 - alpaca-tc:fixed_tiny_typo, r=flip1995

  Show description for a6d6b1b
  bors

  committed
  a6d6b1b

  Copy full SHA for a6d6b1b

• bootstrap: fix wrong docs installation path

  pietroalbini

  committed
  5034b50

  Copy full SHA for 5034b50

• Auto merge of #6657 - ThibsG:FromIterParens, r=llogiq

  Show description for 3784cdf
  bors

  committed
  3784cdf

  Copy full SHA for 3784cdf

• Seal the CommandExt, OsStrExt and OsStringExt traits

  Amanieu

  committed
  bfd1ccf

  Copy full SHA for bfd1ccf

Commits on Feb 11, 2021

• Make suggestion of changing mutability of arguments broader

  hkmatsumoto

  committed
  e03f097

  Copy full SHA for e03f097

• Auto merge of #6650 - daxpedda:cargo-common-metadata-publish, r=flip1995

  Show description for beb49ba
  bors

  committed
  beb49ba

  Copy full SHA for beb49ba

• lintcheck toml: explain why tokei is commented out

  matthiaskrgr

  committed
  1025cd3

  Copy full SHA for 1025cd3

• lintcheck: make the log file be ${source-file}-logs.txt

  Show description for c7241b6
  matthiaskrgr

  committed
  c7241b6

  Copy full SHA for c7241b6

• start a clippy-dev readme and some rough info on how to use lintcheck

  matthiaskrgr

  committed
  cfe154b

  Copy full SHA for cfe154b

• lintcheck: add support for path sources

  matthiaskrgr

  committed
  5e29aa6

  Copy full SHA for 5e29aa6

• lintcheck: collect ICEs

  matthiaskrgr

  committed
  a6d493d

  Copy full SHA for a6d493d

• Auto merge of #6708 - matthiaskrgr:lintcheck, r=flip1995

  Show description for 8dbcffe
  bors

  committed
  8dbcffe

  Copy full SHA for 8dbcffe

• Merge remote-tracking branch 'upstream/master' into rustup

  flip1995

  committed
  00f9981

  Copy full SHA for 00f9981

• Bump nightly version -> 2021-02-11

  flip1995

  committed
  4efc454

  Copy full SHA for 4efc454

• Auto merge of #6718 - flip1995:rustup, r=flip1995

  Show description for 70c0f90
  bors

  committed
  70c0f90

  Copy full SHA for 70c0f90

• Merge commit '70c0f90453701e7d6d9b99aaa1fc6a765937b736' into clippyup

  flip1995

  committed
  d2e2f64

  Copy full SHA for d2e2f64

• Improve long explanation for E0542 and E0546

  jesusprubio

  committed
  a99d869

  Copy full SHA for a99d869

• Fix suggestion to introduce explicit lifetime

  0yoyoyo

  committed
  788e4bb

  Copy full SHA for 788e4bb

• dist: include src/build_helper as part of the crate graph for rustc-dev.

  Show description for f492b25
  bnjbvr

  committed
  f492b25

  Copy full SHA for f492b25

• Rollup merge of #79983 - petar-dambovaliev:master, r=Dylan-DPC

  Show description for 15e1528
  jonas-schievink

  authored
  15e1528

  Copy full SHA for 15e1528

• Rollup merge of #81479 - osa1:issue24151, r=lcnr

  Show description for 660d58f
  jonas-schievink

  authored
  660d58f

  Copy full SHA for 660d58f

• Rollup merge of #81741 - sdroege:zip-trusted-random-access-specialization-panic-safety, r=KodrAus

  Show description for ff5a47d
  jonas-schievink

  authored
  ff5a47d

  Copy full SHA for ff5a47d

• Rollup merge of #81850 - the8472:env-rwlock, r=m-ou-se

  Show description for 9977d8f
  jonas-schievink

  authored
  9977d8f

  Copy full SHA for 9977d8f

• Rollup merge of #81947 - camsteffen:to-ty, r=jyn514

  Show description for 9b03649
  jonas-schievink

  authored
  9b03649

  Copy full SHA for 9b03649

• Rollup merge of #81954 - joshtriplett:release-notes-group-platform-notes, r=XAMPPRocky

  Show description for 316d307
  jonas-schievink

  authored
  316d307

  Copy full SHA for 316d307

• Rollup merge of #81955 - dtolnay:dwp, r=Mark-Simulacrum

  Show description for 732016c
  jonas-schievink

  authored
  732016c

  Copy full SHA for 732016c

• Rollup merge of #81959 - therealprof:fix-typo, r=oli-obk

  Show description for 9fbea53
  jonas-schievink

  authored
  9fbea53

  Copy full SHA for 9fbea53

• Rollup merge of #81964 - lovasoa:patch-1, r=GuillaumeGomez

  Show description for 0127e60
  jonas-schievink

  authored
  0127e60

  Copy full SHA for 0127e60

• Rollup merge of #81968 - pietroalbini:fix-doc-install-path, r=Mark-Simulacrum

  Show description for 06cf63c
  jonas-schievink

  authored
  06cf63c

  Copy full SHA for 06cf63c

• Rollup merge of #81975 - Amanieu:seal2, r=m-ou-se

  Show description for 0fc60ab
  jonas-schievink

  authored
  0fc60ab

  Copy full SHA for 0fc60ab

• Rollup merge of #81990 - matsujika:suggest-mut-reference, r=estebank

  Show description for a96135e
  jonas-schievink

  authored
  a96135e

  Copy full SHA for a96135e

• Rollup merge of #81993 - flip1995:clippyup, r=Manishearth

  Show description for a987ed5
  jonas-schievink

  authored
  a987ed5

  Copy full SHA for a987ed5

• Rollup merge of #81994 - jesusprubio:improve-long-explanation-e0542-e0546, r=GuillaumeGomez

  Show description for cf9266c
  jonas-schievink

  authored
  cf9266c

  Copy full SHA for cf9266c

• Rollup merge of #81995 - 0yoyoyo:fix-issue-81650-explicit-lifetime-error, r=estebank

  Show description for 99e79ea
  jonas-schievink

  authored
  99e79ea

  Copy full SHA for 99e79ea

• Rollup merge of #81997 - bnjbvr:dist-include-build-helper, r=Mark-Simulacrum

  Show description for 98187bb
  jonas-schievink

  authored
  98187bb

  Copy full SHA for 98187bb