Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower async fn in traits. #84168

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Lower async fn in traits. #84168

merged 2 commits into from
Apr 19, 2021

Conversation

cjgillot
Copy link
Contributor

An error is already created by AST validation.

Fixes #84149

An error is already created by AST validation.
@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 13, 2021
@cramertj
Copy link
Member

Can you add a test showing that the linked issue is fixed by this change?

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 19, 2021

📌 Commit a54d575 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 19, 2021
Rollup of 7 pull requests

Successful merges:

 - rust-lang#84123 (Introduce CompileMonoItem DepNode)
 - rust-lang#84126 (Enable sanitizers for x86_64-unknown-linux-musl)
 - rust-lang#84168 (Lower async fn in traits.)
 - rust-lang#84256 (doc: use U+2212 for minus sign in floating-point -0.0 remarks)
 - rust-lang#84291 (fix aliasing violations in thread_local_const_init)
 - rust-lang#84313 (fix suggestion for unsized function parameters)
 - rust-lang#84330 (Remove unused footer section)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e5b5745 into rust-lang:master Apr 19, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 19, 2021
@JohnTitor JohnTitor mentioned this pull request Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
6 participants