Remove unused footer section #84330
Merged
Remove unused footer section #84330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
C-cleanup
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup @GuillaumeGomez this change looks fine, but could you make sure when adding the footer to docs.rs that it works even if rustdoc added its own footer? Otherwise it will break old docs. |
|
📌 Commit 4fa1d61 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 19, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#84123 (Introduce CompileMonoItem DepNode) - rust-lang#84126 (Enable sanitizers for x86_64-unknown-linux-musl) - rust-lang#84168 (Lower async fn in traits.) - rust-lang#84256 (doc: use U+2212 for minus sign in floating-point -0.0 remarks) - rust-lang#84291 (fix aliasing violations in thread_local_const_init) - rust-lang#84313 (fix suggestion for unsized function parameters) - rust-lang#84330 (Remove unused footer section) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized yesterday while working on docs.rs that rustdoc was generating a "footer"section that it doesn't use. No need to keep it then.
r? @jyn514