-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create method overview docs for core::option and core::result #86211
Merged
Commits on Jun 11, 2021
-
Fix some awkward wording in the `core::option` documentation in the "Options and pointers" section.
Configuration menu - View commit details
-
Copy full SHA for cb65b48 - Browse repository at this point
Copy the full SHA cb65b48View commit details -
Fix a typo/missed replacement in the documentation for `impl From<&Option<T>> for Option<&T>` in `core::option`.
Configuration menu - View commit details
-
Copy full SHA for 4763377 - Browse repository at this point
Copy the full SHA 4763377View commit details -
Configuration menu - View commit details
-
Copy full SHA for d54d59b - Browse repository at this point
Copy the full SHA d54d59bView commit details -
Fix an error in `map_or_else`. Use more descriptive text for "don't care" in truth tables. Make minor corrections to truth tables. Rename `makeiter` to `make_iter` in examples.
Configuration menu - View commit details
-
Copy full SHA for 7edc666 - Browse repository at this point
Copy the full SHA 7edc666View commit details -
Configuration menu - View commit details
-
Copy full SHA for 370f731 - Browse repository at this point
Copy the full SHA 370f731View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7265bef - Browse repository at this point
Copy the full SHA 7265befView commit details
Commits on Jun 12, 2021
-
Make minor wording changes in a few places. Move `filter` to the "transformations" section. Add `zip` methods to the "transformations" section. Clarify the section about `Option` iterators, and add a section about collecting into `Option`. Clarify that for `Result`, `or` and `or_else` can also produce a `Result` having a different type.
Configuration menu - View commit details
-
Copy full SHA for 834f4b7 - Browse repository at this point
Copy the full SHA 834f4b7View commit details
Commits on Jun 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1b58d93 - Browse repository at this point
Copy the full SHA 1b58d93View commit details
Commits on Jun 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9a00fd0 - Browse repository at this point
Copy the full SHA 9a00fd0View commit details
Commits on Jun 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 771f35c - Browse repository at this point
Copy the full SHA 771f35cView commit details
Commits on Jun 24, 2021
-
option/result overviews: address feedback
(Most of these are from a review by joshtriplett. Thanks!) Fix errors in `as_pin_ref` and `as_pin_mut` in the "Adapters for working with references" overview. Reword some headings about transformation methods. Reclassify `map`, `map_or`, `map_or_else`, `map_err`, etc. to more accurately reflect which variants they transform. Document `Debug` requirement for `get_or_insert_default`. Reword text about `take` and `replace` to be more accurate. Add examples for the `Product` and `Sum` traits. Also: Move link reference definitions closer to their uses. Warn about making link reference definintions for `err` and `ok`. Avoid making other link reference definitions that might conflict in the future (foreign methods that share a name with local ones, etc.) Write out the generics of `Option` and `Result` when the following text refers to the type parameters.
Configuration menu - View commit details
-
Copy full SHA for c196cc9 - Browse repository at this point
Copy the full SHA c196cc9View commit details
Commits on Jul 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2b4a6aa - Browse repository at this point
Copy the full SHA 2b4a6aaView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.