Provide more context on incorrect inner attribute #88257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
invalid-attr-error
branch
from
ddf7f12 to
9c74002
Compare
estebank
commented
Aug 24, 2021
inquisitivecrystal
added
the
T-compiler
|
Not really familiar with the parsing code, so going to reroll r? rust-lang/compiler-team |
estebank
force-pushed
the
invalid-attr-error
branch
3 times, most recently
from
9c9e3ab to
94f9927
Compare
Suggest changing an inner attribute into an outer attribute if followed by an item.
estebank
force-pushed
the
invalid-attr-error
branch
from
94f9927 to
39ceab0
Compare
|
@bors r+ rollup |
|
📌 Commit 39ceab0 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 5, 2021
Rollup of 4 pull requests Successful merges: - rust-lang#88257 (Provide more context on incorrect inner attribute) - rust-lang#88432 (Fix a typo in raw_vec) - rust-lang#88511 (x.py clippy: don't run with --all-targets by default) - rust-lang#88657 (Fix 2021 `dyn` suggestion that used code as label) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggest changing an inner attribute into an outer attribute if followed by an item.