Stop flagging unexpected inner attributes as outer ones in certain diagnostics #95189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matthewjasper (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
fmease
commented
Mar 22, 2022
fmease
commented
Apr 5, 2022
fmease
commented
Apr 6, 2022
|
@bors r+ |
|
📌 Commit 5ab0548 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 7, 2022
Rollup of 4 pull requests Successful merges: - rust-lang#95189 (Stop flagging unexpected inner attributes as outer ones in certain diagnostics) - rust-lang#95752 (Regression test for rust-lang#82866) - rust-lang#95753 (Correct safety reasoning in `str::make_ascii_{lower,upper}case()`) - rust-lang#95757 (Use gender neutral terms) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94340.
In the issue to-be-fixed I write that the general message an inner attribute is not permitted in this context should be more specific noting that the “context” is the
includemacro. This, however, cannot be achieved without touching a lot of things and passing a flag to theparse_exprandparse_itemcalls inexpand_include. This seems rather hacky to me. That's why I left it as it.Span::from_expansiondoes not apply either AFAIK.@rustbot label A-diagnostics T-compiler