Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.56.0 release notes #88893

Merged
merged 1 commit into from
Sep 25, 2021
Merged

Add 1.56.0 release notes #88893

merged 1 commit into from
Sep 25, 2021

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Sep 12, 2021

Notable things:

  • Rustdoc section currently absent, for lack of things to call out that I could find. It seems like Add support for tuple struct field documentation #87451 is the only potential candidate, but that seems like more of a bugfix and doesn't seem to warrant inclusion to me. But we can add it if desired.

As with the 1.55.0 release notes, my intent is to leave this open for approximately 1-2 weeks at the early part of the cycle, and then merge it in (after fixing any feedback). Further iteration can happen in subsequent issues (and PRs).

Rendered

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 12, 2021
@Mark-Simulacrum Mark-Simulacrum added T-release Relevant to the release subteam, which will review and decide on the PR/issue. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2021
RELEASES.md Show resolved Hide resolved
@jyn514
Copy link
Member

jyn514 commented Sep 13, 2021

If we're including bugfixes, #88019 is another good ones, it fixes a metric ton of issues with rustdoc and macros.

#87728 and #87050 might be good to mention in compatibility notes (not sure if they're major enough since it's only a warning).

Other than that I agree there's not a lot.

RELEASES.md Show resolved Hide resolved
@tschuett
Copy link

I would love a rendered link. I would also enjoy #88250. PGO builds for other targets would also be nice.

@Mark-Simulacrum
Copy link
Member Author

#88250 is nightly-only, right? We don't mention nightly-only things in release notes.

@Mark-Simulacrum
Copy link
Member Author

#87728 and #87050 might be good to mention in compatibility notes (not sure if they're major enough since it's only a warning).

I intentionally didn't include things that are "obviously" made incompatible in this release with just warnings.

@Mark-Simulacrum
Copy link
Member Author

Thanks everyone for their review!

Co-authored-by: Josh Triplett <josh@joshtriplett.org>
@pietroalbini
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 24, 2021

📌 Commit a307dcc has been approved by pietroalbini

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 24, 2021
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 24, 2021
…lbini

Add 1.56.0 release notes

Notable things:

* Rustdoc section currently absent, for lack of things to call out that I could find. It seems like rust-lang#87451 is the only potential candidate, but that seems like more of a bugfix and doesn't seem to warrant inclusion to me. But we can add it if desired.

As with the 1.55.0 release notes, my intent is to leave this open for approximately 1-2 weeks at the early part of the cycle, and then merge it in (after fixing any feedback). Further iteration can happen in subsequent issues (and PRs).

[Rendered](https://github.com/Mark-Simulacrum/rust/blob/relnotes/RELEASES.md)
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 25, 2021
…ingjubilee

Rollup of 8 pull requests

Successful merges:

 - rust-lang#88893 (Add 1.56.0 release notes)
 - rust-lang#89001 (Be explicit about using Binder::dummy)
 - rust-lang#89072 (Avoid a couple of Symbol::as_str calls in cg_llvm )
 - rust-lang#89104 (Simplify scoped_thread)
 - rust-lang#89208 ([rfc 2229] Drop fully captured upvars in the same order as the regular drop code)
 - rust-lang#89210 (Add missing time complexities to linked_list.rs)
 - rust-lang#89217 (Enable "generate-link-to-definition" option on rust tools docs as well)
 - rust-lang#89221 (Give better error for `macro_rules! name!`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2de7f10 into rust-lang:master Sep 25, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.