Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid a couple of Symbol::as_str calls in cg_llvm #89072

Merged
merged 3 commits into from
Sep 25, 2021

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Sep 18, 2021

This should improve performance a tiny bit. Also remove Symbol::len and make SymbolIndex private.

@bjorn3 bjorn3 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 18, 2021
@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2021
@bors
Copy link
Contributor

bors commented Sep 19, 2021

☔ The latest upstream changes (presumably #89089) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Member

@michaelwoerister michaelwoerister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bjorn3! r=me once rebased.

It is used exactly once and can be replaced with the equally fast
.as_str().len()
@bjorn3
Copy link
Member Author

bjorn3 commented Sep 22, 2021

@bors r=michaelwoerister

@bors
Copy link
Contributor

bors commented Sep 22, 2021

📌 Commit df72749 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2021
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 24, 2021
…lwoerister

Avoid a couple of Symbol::as_str calls in cg_llvm

This should improve performance a tiny bit. Also remove `Symbol::len` and make `SymbolIndex` private.
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 25, 2021
…ingjubilee

Rollup of 8 pull requests

Successful merges:

 - rust-lang#88893 (Add 1.56.0 release notes)
 - rust-lang#89001 (Be explicit about using Binder::dummy)
 - rust-lang#89072 (Avoid a couple of Symbol::as_str calls in cg_llvm )
 - rust-lang#89104 (Simplify scoped_thread)
 - rust-lang#89208 ([rfc 2229] Drop fully captured upvars in the same order as the regular drop code)
 - rust-lang#89210 (Add missing time complexities to linked_list.rs)
 - rust-lang#89217 (Enable "generate-link-to-definition" option on rust tools docs as well)
 - rust-lang#89221 (Give better error for `macro_rules! name!`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8a454f8 into rust-lang:master Sep 25, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 25, 2021
@bjorn3 bjorn3 deleted the less_symbol_as_str branch September 25, 2021 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants