Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relate lifetime in TypeOutlives bounds on drop impls #90840

Merged
merged 1 commit into from
Nov 14, 2021
Merged

relate lifetime in TypeOutlives bounds on drop impls #90840

merged 1 commit into from
Nov 14, 2021

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Nov 12, 2021

Fixes #90838

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2021
@camelid camelid added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 12, 2021
@jackh726
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 13, 2021

📌 Commit 875024c has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2021
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 13, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2021
@bors
Auto merge of rust-lang#90883 - matthiaskrgr:rollup-iu9k5pe, r=matthi…
589ad6a 
…askrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#90771 (Fix trait object error code)
 - rust-lang#90840 (relate lifetime in `TypeOutlives` bounds on drop impls)
 - rust-lang#90853 (rustdoc: Use an empty Vec instead of Option<Vec>)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e273fab into rust-lang:master Nov 14, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 14, 2021
@WaffleLapkin
Copy link
Member

Should this also be backported to 1.56 and 1.57?

@jackh726 jackh726 added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Nov 14, 2021
@apiraino
Copy link
Contributor

Beta backports decision deferred to next meeting (discussion on Zulip)

@pnkfelix would like to investigate whether the TypeOutlives arm is actually used or not (perhaps try to remove it outright and see if the tests fail).

This was referenced Nov 22, 2021
Closed
Closed
@apiraino
Copy link
Contributor

Beta backport accepted as per compiler team on Zulip, in favor of #91136

The stable nomination is declined since we are close to the release (next week).

@rustbot label +beta-accepted -stable-nominated

@rustbot rustbot added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed stable-nominated Nominated for backporting to the compiler in the stable channel. labels Nov 24, 2021
@Aaron1011
Copy link
Member

Did this end up getting beta backported?

@jackh726
Copy link
Member

Not yet

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Nov 26, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 27, 2021
@bors
Auto merge of rust-lang#91263 - Mark-Simulacrum:beta-next, r=Mark-Sim…
7e15b23 
…ulacrum

[beta] backports

* relate lifetime in TypeOutlives bounds on drop impls rust-lang#90840
*  [beta] [1.57] Disable LLVM newPM by default rust-lang#91189

r? `@Mark-Simulacrum`
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.58.0, 1.57.0 Nov 29, 2021
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidtwco davidtwco

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.

Unsound drop due to imperfect lifetime checks