-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beta] [1.57] Disable LLVM newPM by default #91189
Conversation
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
|
I went ahead and unilaterally specified the |
This comment has been minimized.
This comment has been minimized.
(Just noting it might be helpful to add some explanation of why this change is being made to the PR description.) |
d31a65a
to
5026492
Compare
Thanks for the description ❤️
@bors rollup=never |
One pretty concerning thing I just realised now is that we pretty much had almost no testing of LLVM 13.0 with the oldPM, unless people were really heavily using the |
This PR is filed against beta and marked as beta-accepted. Usually, one would just open a PR against master (#91190) and mark that as beta-accepted. Then someone from the release team will backport it. |
I believe the LLVM 13 upgrade landed in 1.56 already, so it was tested in that release cycle. Though you're right that 1.57 did not receive any testing with the legacy PM. |
…ulacrum [beta] backports * relate lifetime in TypeOutlives bounds on drop impls rust-lang#90840 * [beta] [1.57] Disable LLVM newPM by default rust-lang#91189 r? `@Mark-Simulacrum`
This has been landed in #91263. |
This is a temporary solution until we manage to get some sort of a workaround for the rampant inlining behaviour and other issues such as #91128 in place. Expect significant compilation time regressions in other areas, though.