-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix toggle-click-deadspace rustdoc-gui test #91171
Conversation
Considering it's breaking the CI, setting a slightly higher priority. @bors: r+ p=1 |
📌 Commit 420be4a has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (982c552): comparison url. Summary: This change led to very large relevant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression |
Euh. What? Why are there perf changes in here? XD |
cc rust-lang/rustc-perf#1105, spurious change, dropping regression label. |
In #91103 I introduced a rustdoc-gui test for clicks on toggles. I introduced some documentation on a method in lib2/struct.Foo.html so there would be something to toggle, but accidentally left the test checking test_docs/struct.Foo.html. That caused the test to reliably fail.
I'm not sure how that test got past GitHub Actions and bors, but it's manifesting in test failures at #91062 (comment) and #91170 (comment).
This fixes by pointing at the right file.
r? @GuillaumeGomez