Generalize "remove &" and "add *" suggestions to more than one deref
#91545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
compiler-errors
force-pushed
the
deref-suggestion-improvements
branch
from
d494432
to
c432afe
Compare
apiraino
added
the
T-compiler
camelid
reviewed
Jan 10, 2022
|
☔ The latest upstream changes (presumably #92883) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
force-pushed
the
deref-suggestion-improvements
branch
from
c432afe
to
f9be623
Compare
rustbot
added
S-waiting-on-author
JohnCSimon
added
S-waiting-on-review
|
Ping from triage: |
|
@JohnCSimon given that this has gone almost 3 months without review, I apologize for not keeping up with rebasing this every time bors tells me that it newly fails to merge. Should I re-roll for a new highfive reviewer, or @estebank do you plan on taking a look at this sometime in the near future? Thanks! |
|
I will rebase this again, just for good measure. |
compiler-errors
force-pushed
the
deref-suggestion-improvements
branch
from
f9be623
to
d1647f4
Compare
compiler-errors
force-pushed
the
deref-suggestion-improvements
branch
from
d1647f4
to
5ce3f56
Compare
|
r? @jackh726 |
|
@bors r+ |
|
📌 Commit 5ce3f56 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 1, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#91545 (Generalize "remove `&`" and "add `*`" suggestions to more than one deref) - rust-lang#93385 (Rustdoc ty consistency fixes) - rust-lang#93926 (Lint against more useless `#[must_use]` attributes) - rust-lang#94094 (use BOOL for TCP_NODELAY setsockopt value on Windows) - rust-lang#94384 (Add Atomic*::from_mut_slice) - rust-lang#94448 (5 - Make more use of `let_chains`) - rust-lang#94452 (Sync portable-simd for bitmasks &c.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggest removing more than one
&and&mut, along with suggesting adding more than one*(or a combination of the two).r? @estebank
(since you're experienced with these types of suggestions, feel free to reassign)