Lint against more useless #[must_use] attributes
#93926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
PatchMixolydic
commented
Feb 12, 2022
This comment has been minimized.
This comment has been minimized.
PatchMixolydic
commented
Feb 12, 2022
PatchMixolydic
force-pushed
the
bugfix/must_use-on-exprs
branch
2 times, most recently
from
155601f
to
06e6d37
Compare
|
@bors r+ |
|
📌 Commit 06e6d37f23f6e9934310380eee06eca977a6e770 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 06e6d37f23f6e9934310380eee06eca977a6e770 with merge 054616ddf350f630418dc6221a3a0db6ff74531d... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
cjgillot
added
S-waiting-on-author
This expands the existing `#[must_use]` check in `unused_attributes` to lint against pretty much everything `#[must_use]` doesn't support. Fixes rust-lang#93906.
PatchMixolydic
force-pushed
the
bugfix/must_use-on-exprs
branch
from
06e6d37
to
6dcf5d8
Compare
|
I'm hoping the missing |
rustbot
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 6dcf5d8 has been approved by |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 1, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#91545 (Generalize "remove `&`" and "add `*`" suggestions to more than one deref) - rust-lang#93385 (Rustdoc ty consistency fixes) - rust-lang#93926 (Lint against more useless `#[must_use]` attributes) - rust-lang#94094 (use BOOL for TCP_NODELAY setsockopt value on Windows) - rust-lang#94384 (Add Atomic*::from_mut_slice) - rust-lang#94448 (5 - Make more use of `let_chains`) - rust-lang#94452 (Sync portable-simd for bitmasks &c.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the existing
#[must_use]check inunused_attributesto lint against pretty much everything#[must_use]doesn't support.Fixes #93906.