Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement tuple array diagnostic #92963

Merged
merged 1 commit into from
Jan 22, 2022
Merged

Implement tuple array diagnostic #92963

merged 1 commit into from
Jan 22, 2022

Conversation

terrarier2111
Copy link
Contributor

Fixes #92089

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 16, 2022
@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 16, 2022
davidtwco
davidtwco requested changes Jan 17, 2022
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good addition, left some small nits on the error wording and the naming of some things.

compiler/rustc_typeck/src/check/callee.rs Outdated Show resolved Hide resolved
src/test/ui/tuple/array-diagnostics.rs Outdated Show resolved Hide resolved
compiler/rustc_typeck/src/check/callee.rs Outdated Show resolved Hide resolved
compiler/rustc_typeck/src/check/callee.rs Outdated Show resolved Hide resolved
@davidtwco davidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2022
@terrarier2111
Implement tuple array diagnostic
ef46e38 
Co-authored-by: David Wood <Q0KPU0H1YOEPHRY1R2SN5B5RL@david.davidtw.co>
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 21, 2022

📌 Commit ef46e38 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 21, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 21, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 21, 2022
@bors
Auto merge of rust-lang#93173 - matthiaskrgr:rollup-49bj7ta, r=matthi…
ecf7299 
…askrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#91965 (Add more granular `--exclude` in `x.py`)
 - rust-lang#92467 (Ensure that early-bound function lifetimes are always 'local')
 - rust-lang#92586 (Set the allocation MIN_ALIGN for espidf to 4.)
 - rust-lang#92835 (Improve error message for key="value" cfg arguments.)
 - rust-lang#92843 (Improve string concatenation suggestion)
 - rust-lang#92963 (Implement tuple array diagnostic)
 - rust-lang#93046 (Use let_else in even more places)
 - rust-lang#93109 (Improve `Arc` and `Rc` documentation)
 - rust-lang#93134 (delete `Stdin::split` forwarder)
 - rust-lang#93139 (rustdoc: fix overflow-wrap for table layouts)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1f3a2dd into rust-lang:master Jan 22, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.

Unhelpful error when array elements aren't separated by commas
5 participants
@terrarier2111 @rust-highfive @davidtwco @bors @rustbot