Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] 1.59.0 artifacts (second round) #94265

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

Mark-Simulacrum
Copy link
Member

This backports (from 1.60, landed in #93001):

Per a user report on the internals feedback thread, this lint is not behaving well in 1.59.

cc @rust-lang/clippy -- this is a stable backport of a patch, which we'll likely want to land in fairly short order to be in time for the release Thursday.

This PR also includes an adjustment to the release notes to reflect "Fix invalid special casing of the unreachable! macro #93179".

r? @Mark-Simulacrum

@rust-highfive
Copy link
Collaborator

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 22, 2022
@Mark-Simulacrum
Copy link
Member Author

@bors r+ rollup=never p=100

@bors
Copy link
Contributor

bors commented Feb 22, 2022

📌 Commit 6bd1b5f has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2022
@bors
Copy link
Contributor

bors commented Feb 23, 2022

⌛ Testing commit 6bd1b5f with merge 4d4c42ee7f6e342d9e29161f020e3c3443730c7e...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Feb 23, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 23, 2022
@Mark-Simulacrum
Copy link
Member Author

@bors retry macos runner missing

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2022
@bors
Copy link
Contributor

bors commented Feb 23, 2022

⌛ Testing commit 6bd1b5f with merge 9d1b210...

@bors
Copy link
Contributor

bors commented Feb 23, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 9d1b210 to stable...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 23, 2022
@bors bors merged commit 9d1b210 into rust-lang:stable Feb 23, 2022
@rustbot rustbot added this to the 1.59.0 milestone Feb 23, 2022
@Mark-Simulacrum Mark-Simulacrum deleted the stable-next branch February 25, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants