Out of cycle Clippy update #93001
Merged
Out of cycle Clippy update #93001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ef_to_type_aliases, r=llogiq Apply `not_unsafe_ptr_arg_deref` to type aliases changelog: Apply [`not_unsafe_ptr_arg_deref`] to type aliases
Fix `implicit_clone` for `&&T` fixes rust-lang#8227 changelog: Don't lint `implicit_clone` on `&&T`
…5, r=Manishearth Erase late bound regions in `iter_not_returning_iterator` fixes rust-lang#8285 changelog: None
…d does not show the solution
Update markdown-it version Fixes improperly-escaped pipes in Markdown tables for the [documentation of bad_bit_mask](https://rust-lang.github.io/rust-clippy/master/index.html#bad_bit_mask) and [ineffective_bit_mask](https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_bit_mask). A column pipe takes precedence over inline code markers, so some back ticks are displayed literally and the pipes need to be escaped. I found no other occurrences of the same problem when searching rust-clippy by ```\|.*`.*\|```. changelog: Update markdown-it version
…am-procrastinating, r=giraffate Update copyright year for Clippy (2022 edition) At this point, I'm just searching for small things to do instead of sleeping or working on my bachelor thesis. 😅 Taking one day off will be fine 🙃 changelog: none
Handle implicit named arguments in `useless_format` fixes rust-lang#8290 Ideally this would fix the macro parsing code to handle this, but this is a smaller change and easier to back port. changelog: Handle implicit named arguments in `useless_format`
New lint: `iter_overeager_cloned` Closes rust-lang#8202 changelog: New lint: [`iter_overeager_cloned`]
…hearth Don't lint `if_same_then_else` with `if let` conditions fixes rust-lang#7579 changelog: Don't lint `if_same_then_else` with `if let` conditions
rust-lang#8214 cmp_owned suggestion flips the comparison changelog: ``[`cmp_owned`]`` fixes rust-lang#8214 so that the suggestion does not flip the comparison
|
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
rust-highfive
added
the
S-waiting-on-review
|
Setting this to WIP, since we want to include one more PR. |
issue rust-lang#8239: Printed hint for lint or_fun_call is cropped and does no… fixes rust-lang/rust-clippy#8239 changelog: [`or_fun_call`]: if suggestion contains more lines than MAX_SUGGESTION_HIGHLIGHT_LINES it is stripped to one line
Done! |
|
@bors r+ p=1 |
|
📌 Commit 0fc3fda has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 0fc3fda with merge 24917a3235171e072aa6a04598ae42bbd7d6b854... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (e4ff903): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 27, 2022
Out of cycle Clippy update I want to do an out-of-cycle sync for rust-lang/rust-clippy#8295, and possibly backport this to stable together with rust-lang#92938. If this doesn't get backported to stable, then I at least want to backport it to beta. r? `@Manishearth`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 23, 2022
…imulacrum [stable] 1.59.0 artifacts (second round) This backports (from 1.60, landed in rust-lang#93001): * Move return_self_not_must_use to pedantic rust-lang/rust-clippy#8302 Per a user report on the internals feedback thread, this lint is not behaving well in 1.59. cc `@rust-lang/clippy` -- this is a stable backport of a patch, which we'll likely want to land in fairly short order to be in time for the release Thursday. This PR also includes an adjustment to the release notes to reflect "Fix invalid special casing of the unreachable! macro rust-lang#93179". r? `@Mark-Simulacrum`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to do an out-of-cycle sync for rust-lang/rust-clippy#8295, and possibly backport this to stable together with #92938. If this doesn't get backported to stable, then I at least want to backport it to beta.
r? @Manishearth