Do not allow #[rustc_legacy_const_generics] on methods
#94686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
You mean “do not allow,” right? |
|
@notriddle Isn't it exactly what I wrote? |
|
@ChayimFriedman2, I think notriddle means there is a typo in the PR title. |
jackh726
changed the title
#[rustc_legacy_const_generics] on methods#[rustc_legacy_const_generics] on methods
|
The same typo is also in the commit message. |
It caused an ICE since `item` was `None`.
ChayimFriedman2
force-pushed
the
issue-94629
branch
from
ae05bfa
to
96515f4
Compare
|
Oh yeah, my bad. Fixed it. |
|
@bors r+ rollup |
|
📌 Commit 96515f4 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 9, 2022
…h726 Do not allow `#[rustc_legacy_const_generics]` on methods It caused an ICE since `item` was `None`. Fixes rust-lang#94629.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 9, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#94312 (Edit `rustc_trait_selection::infer::lattice` docs) - rust-lang#94583 (Add a team for '`@rustbot` ping fuchsia') - rust-lang#94686 (Do not allow `#[rustc_legacy_const_generics]` on methods) - rust-lang#94699 (BTree: remove dead data needlessly complicating insert) - rust-lang#94756 (Use `unreachable!` for an unreachable code path) - rust-lang#94759 (Update cargo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It caused an ICE since
itemwasNone.Fixes #94629.