Use unreachable! for an unreachable code path
#94756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @yaahc (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ I kinda wanted to put a more helpful error message here even though it's not supposed to be reachable, but it doesn't look like we do that with any of our other |
|
📌 Commit 57442be has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 9, 2022
Use `unreachable!` for an unreachable code path Closes rust-lang#73212
|
⌛ Testing commit 57442be with merge f93e11eb342e6a90031af053090c41e53a2ce37f... |
|
@bors retry (yield to rollup containing this pr) |
|
⌛ Testing commit 57442be with merge 72f3846764bfe84608d0214597f0bb8dd36b67a5... |
|
@bors retry |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 9, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#94312 (Edit `rustc_trait_selection::infer::lattice` docs) - rust-lang#94583 (Add a team for '`@rustbot` ping fuchsia') - rust-lang#94686 (Do not allow `#[rustc_legacy_const_generics]` on methods) - rust-lang#94699 (BTree: remove dead data needlessly complicating insert) - rust-lang#94756 (Use `unreachable!` for an unreachable code path) - rust-lang#94759 (Update cargo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73212