Switch to gender neutral terms #95508
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
added
T-compiler
rust-highfive
added
the
S-waiting-on-review
| ``` | ||
| struct Simba { | ||
| mother: u32, | ||
| father: u32, | ||
| parent: u32, | ||
| parent: u32, | ||
| } |
There was a problem hiding this comment.
🤔 I don't think this will compile
There was a problem hiding this comment.
Please familiarize yourself with the limitations of CAN-SPAM and other laws restricting submitting unsolicited messages, @jamiepinheiro. I do not want you to fall afoul of international legal trouble because of a well-intentioned programming experiment.
| // The attacker wants to get directory contents deleted, to which they does not have access. | ||
| // They has a way to get a privileged Rust binary call `std::fs::remove_dir_all()` on a | ||
| // directory they controls, e.g. in their home directory. |
There was a problem hiding this comment.
Unfortunately, "contribution" via regex, without human oversight, is not a good strategy. Pronouns are not context-free. It is "they do not have". I think this is the only legitimate example of something we might want to change, and it is still wrong and thus cannot be merged.
| @@ -454,7 +454,7 @@ impl str { | |||
| /// assert!(v.get_mut(0..5).is_some()); | |||
| /// // out of bounds | |||
| /// assert!(v.get_mut(..42).is_none()); | |||
| /// assert_eq!(Some("he"), v.get_mut(0..2).map(|v| &*v)); | |||
| /// assert_eq!(Some("they"), v.get_mut(0..2).map(|v| &*v)); | |||
There was a problem hiding this comment.
Hello, @jamiepinheiro Your bot is busted. "he" is used here not as a pronoun but as a random two-character string.
| @@ -980,7 +980,7 @@ pub mod fast { | |||
| unsafe fn try_initialize<F: FnOnce() -> T>(&self, init: F) -> Option<&'static T> { | |||
| // SAFETY: See comment above (this function doc). | |||
| if !mem::needs_drop::<T>() || unsafe { self.try_register_dtor() } { | |||
| // SAFETY: See comment above (his function doc). | |||
| // SAFETY: See comment above (their function doc). | |||
There was a problem hiding this comment.
Many examples are just typos.
| @@ -13,7 +13,7 @@ pub enum MaybeDog { | |||
|
|
|||
| impl MaybeDog { | |||
| fn bark() { | |||
| // If this provides a suggestion, it's a bug as MaybeDog doesn't impl Groom | |||
| // If this provides a suggestion, it's a bug as MaybeDog doesn't impl Newlywed | |||
There was a problem hiding this comment.
"Groom" has other meanings, as it is also a verb, amongst other things.
| @@ -7,7 +7,7 @@ pub struct Foo; | |||
| /// And then, the princess died. | |||
| //~^ ERROR missing code example in this documentation | |||
| pub mod foo { | |||
| /// Or maybe not because she saved herself! | |||
| /// Or maybe not because they saved herself! | |||
There was a problem hiding this comment.
Many examples would make it contextually incorrect e.g. when there is a discussion of a hypothetical entity who IS gendered. It would require a much more careful revision.
|
This bot's modus operandi seems to be to repeatedly spam PRs until someone accepts them or blocks them, e.g. facebook/react#24223 I recommend blocking both the bot and its author (one of them, anyways) so that further exercises like this one constitute block evasion. Limiting further engagement until then because its actions have also been attracting heat from random passerby, not just maintainers. |
workingjubilee
removed
T-rustdoc
Hey! We noticed your repository had a few instances of gendered language. We've attempted to make the changes to gender neutral language using these substitions - joelparkerhenderson/gender-inclusive-language. These are not always perfect, but we hope they will assist maintainers in finding and fixing issues :)
You can learn more about this project and why gender neutral language matters at inclusivecoding.wixsite.com. If you have feedback for this bot, please provide it here.