Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #95511

Merged
merged 10 commits into from
Mar 31, 2022
Merged

Rollup of 5 pull requests #95511

merged 10 commits into from
Mar 31, 2022

Conversation

Dylan-DPC
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

jyn514 and others added 10 commits March 29, 2022 14:56
This has been present since `builder.ensure` was first added in rust-lang#43059.
It's unclear to me why it was added then - I tested these changes locally
with `x test compiler/rustc_data_structures --stage 0` and they worked fine.

Fixes rust-lang#51748.
Fix a minor typo from rust-lang#95241 which prevented compilation on x86_64-unknown-openbsd.
Don't build the full compiler before running unit tests

This has been present since `builder.ensure` was first added in rust-lang#43059.
It's unclear to me why it was added then - I tested these changes locally
with `x test compiler/rustc_data_structures --stage 0` and they worked fine.

Fixes rust-lang#51748.
…t, r=notriddle

Fix last rustdoc-gui spurious test

This should the last spurious failing GUI test from rust-lang#93784.

r? ``@notriddle``
…rgemove_note, r=compiler-errors

Add note to the move size diagnostic

context: rust-lang#83518
…g, r=notriddle

Remove unneeded `to_string` call

Fixes a confusion I made when reading `@camelid's` comment [here](rust-lang#95096 (comment)).

r? `@notriddle`
…, r=dtolnay

Fix library/std compilation on openbsd.

Fix a minor typo from rust-lang#95241 which prevented compilation on x86_64-unknown-openbsd.
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Mar 31, 2022
@Dylan-DPC
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Mar 31, 2022

📌 Commit 0b71ca8 has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 31, 2022
@bors
Copy link
Contributor

bors commented Mar 31, 2022

⌛ Testing commit 0b71ca8 with merge 0331491...

@bors
Copy link
Contributor

bors commented Mar 31, 2022

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 0331491 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 31, 2022
@bors bors merged commit 0331491 into rust-lang:master Mar 31, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 31, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0331491): comparison url.

Summary: This benchmark run did not return any relevant results. 2 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants