Update Clippy #97730
Merged
Update Clippy #97730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop Tracking: Implement `fake_read` callback This PR updates drop tracking's use of `ExprUseVisitor` so that we treat `fake_read` events as borrows. Without doing this, we were not handling match expressions correctly, which showed up as a breakage in the `addassign-yield.rs` test. We did not previously notice this because we still had rather large temporary scopes that we held borrows for, which changed in rust-lang#94309. This PR also includes a variant of the `addassign-yield.rs` test case to make sure we continue to have correct behavior here with drop tracking. r? `@nikomatsakis`
Auto-detect preferred colorscheme changelog: none This just sets the theme to coal by default if the user prefers dark color schemes. r? `@xFrednet`
previously only vecs were supported
remove region_scope_tree from RegionCtxt Apply suggestions from code review Co-authored-by: Niko Matsakis <niko@alum.mit.edu>
Remove feature: `crate` visibility modifier FCP completed in rust-lang#53120.
Strip `clippy::` prefix from search strings changelog: none closes: rust-lang#8865 r? `@xFrednet`
…rk-Simulacrum Lifetime variance fixes for clippy rust-lang#97287 migrates rustc to a `Ty` type that is invariant over its lifetime `'tcx`, so I need to fix a bunch of places that assume that `Ty<'a>` and `Ty<'b>` can be shortened to some common lifetime. This is doable, since everything is already `'tcx`, so all this PR does is be a bit more explicit that elided lifetimes are actually `'tcx`. Split out from rust-lang#97287 so the clippy team can review independently.
update dependencies changelog: none Updating some dependencies, but the biggest one is clap to v3, but without using the derive struct thingy.
…-obk Refactor call terminator to always include destination place In rust-lang#71117 people seemed to agree that call terminators should always have a destination place, even if the call was guaranteed to diverge. This implements that. Unsurprisingly, the diff touches a lot of code, but thankfully I had to do almost nothing interesting. The only interesting thing came up in const prop, where the stack frame having no return place was also used to indicate that the layout could not be computed (or similar). I replaced this with a ZST allocation, which should continue to do the right things. cc `@RalfJung` `@eddyb` who were involved in the original conversation r? rust-lang/mir-opt
Closes rust-lang#1595 changelog: Add no_effect_replace lint.
The import of `clippy_utils::is_type_diagnostic_item` would cause this error: ``` error[E0432]: unresolved import `clippy_utils::is_type_diagnostic_item ```
New lint `no_effect_replace` Closes rust-lang#1595 Signed-off-by: Federico Guerinoni <guerinoni.federico@gmail.com> changelog: Add [`no_effect_replace`] lint.
|
⌛ Testing commit 586cbd0 with merge b69e546c2c8cd386ff25f08dde638f8b0944dbf6... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Not sure if that is the correct fix or if it works. I don't have access to a windows machine to test it, so @bors try |
|
⌛ Trying commit 9525e0c with merge 05b9818f249e102127c58ea7c35f640c5f696114... |
|
Oh a try run doesn't run the all of the runners. In that case, I'm just waiting on a review. |
|
☀️ Try build successful - checks-actions |
|
Hmm, I don't feel confident enough to |
|
@bors r+ I think rustc is in general fine with parking_lot deps |
|
📌 Commit 9525e0c has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (50b0025): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesThis benchmark run did not return any relevant results for this metric. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
This was referenced Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth
This includes a bit bigger
Cargo.lockupdate.