Point at private fields in struct literal #98283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaKO8Ki
changed the title
rustbot
added
the
T-compiler
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| note: missing field `private` is private | ||
| --> $DIR/issue-79593.rs:2:22 | ||
| | | ||
| LL | pub struct Pub { private: () } |
There was a problem hiding this comment.
Hm, maybe we shouldn't actually point out private fields' definition. It seems like excessive info and showing a private field is kinda against its own purpose...
| LL | a: (), | ||
| | ----- private field | ||
| LL | b: (), | ||
| | ----- private field |
There was a problem hiding this comment.
Maybe just a note with something like "... and other private fields that were not provided" instead of pointing out the actual fields in the struct definition?
compiler-errors
approved these changes
Jun 22, 2022
|
@bors delegate+ |
|
✌️ @TaKO8Ki can now approve this pull request |
TaKO8Ki
force-pushed
the
point-at-private-fields-in-struct-literal
branch
from
b37f5d3
to
eb86daa
Compare
|
@bors r=compiler-errors |
|
📌 Commit eb86daa has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 22, 2022
…struct-literal, r=compiler-errors Point at private fields in struct literal closes rust-lang#95872
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jun 23, 2022
…struct-literal, r=compiler-errors Point at private fields in struct literal closes rust-lang#95872
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 24, 2022
…piler-errors Rollup of 16 pull requests Successful merges: - rust-lang#96173 (Fix documentation for `with_capacity` and `reserve` families of methods) - rust-lang#98184 (Give name if anonymous region appears in impl signature) - rust-lang#98259 (Greatly improve error reporting for futures and generators in `note_obligation_cause_code`) - rust-lang#98269 (Provide a `PathSegment.res` in more cases) - rust-lang#98283 (Point at private fields in struct literal) - rust-lang#98305 (prohibit_generics: don't alloc error string if no error emitted) - rust-lang#98310 (rustdoc: optimize loading of source sidebar) - rust-lang#98353 (Migrate two diagnostics from the `rustc_builtin_macros` crate) - rust-lang#98355 (Update no_default_libraries handling for emscripten target) - rust-lang#98364 (clarify Arc::clone overflow check comment) - rust-lang#98365 (Address review comments from rust-lang#98259) - rust-lang#98388 (implement `iter_projections` function on `PlaceRef`) - rust-lang#98390 (Fixes handling of keywords in rustdoc json output) - rust-lang#98409 (triagebot.toml: Allow applying nominated labels) - rust-lang#98410 (Update books) - rust-lang#98422 (Update browser-ui-test version to 0.9.6) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #95872