Rollup of 16 pull requests #98438
Merged
Rollup of 16 pull requests #98438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation for the following methods
with_capacity
with_capacity_in
with_capacity_and_hasher
reserve
reserve_exact
try_reserve
try_reserve_exact
was inconsistent and often not entirely correct where they existed on the following types
Vec
VecDeque
String
OsString
PathBuf
BinaryHeap
HashSet
HashMap
BufWriter
LineWriter
since the allocator is allowed to allocate more than the requested capacity in all such cases, and will frequently "allocate" much more in the case of zero-sized types (I also checked BufReader, but there the docs appear to be accurate as it appears to actually allocate the exact capacity).
Some effort was made to make the documentation more consistent between types as well.
Fix with_capacity* methods for Vec
Fix *reserve* methods for Vec
Fix docs for *reserve* methods of VecDeque
Fix docs for String::with_capacity
Fix docs for *reserve* methods of String
Fix docs for OsString::with_capacity
Fix docs for *reserve* methods on OsString
Fix docs for with_capacity* methods on HashSet
Fix docs for *reserve methods of HashSet
Fix docs for with_capacity* methods of HashMap
Fix docs for *reserve methods on HashMap
Fix expect messages about OOM in doctests
Fix docs for BinaryHeap::with_capacity
Fix docs for *reserve* methods of BinaryHeap
Fix typos
Fix docs for with_capacity on BufWriter and LineWriter
Fix consistent use of `hasher` between `HashMap` and `HashSet`
Fix warning in doc test
Add test for capacity of vec with ZST
Fix doc test error
…bligation_cause_code` Most futures don't go through this code path, because they're caught by `maybe_note_obligation_cause_for_async_await`. But all generators do, and `maybe_note` is imperfect and doesn't catch all futures. Improve the error message for those it misses. At some point, we may want to consider unifying this with the code for `maybe_note_async_await`, so that `async_await` notes all parent constraints, and `note_obligation` can point to yield points. But both functions are quite complicated, and it's not clear to me how to combine them; this seems like a good incremental improvement.
The source sidebar has a setting to remember whether it should be open or closed. Previously, this setting was handled in source-script.js, which is loaded with `defer`, meaning it is often run after the document is rendered. Since CSS renders the source sidebar as closed by default, changing this after the initial render results in a relayout. Instead, handle the setting in storage.js, which is the first script to load and is the only script that blocks render. This avoids a relayout and means navigating between files with the sidebar open is faster.
It got merged so fast I didn't have time to make changes xD
this makes the api more flexible. the original function now calls the PlaceRef version to avoid duplicating the code.
This seems likely to help more than it would hurt; let's see how it goes.
This update provides a better error message when chromium crashes
…ix, r=Dylan-DPC Fix documentation for `with_capacity` and `reserve` families of methods Fixes rust-lang#95614 Documentation for the following methods - `with_capacity` - `with_capacity_in` - `with_capacity_and_hasher` - `reserve` - `reserve_exact` - `try_reserve` - `try_reserve_exact` was inconsistent and often not entirely correct where they existed on the following types - `Vec` - `VecDeque` - `String` - `OsString` - `PathBuf` - `BinaryHeap` - `HashSet` - `HashMap` - `BufWriter` - `LineWriter` since the allocator is allowed to allocate more than the requested capacity in all such cases, and will frequently "allocate" much more in the case of zero-sized types (I also checked `BufReader`, but there the docs appear to be accurate as it appears to actually allocate the exact capacity). Some effort was made to make the documentation more consistent between types as well.
…impl-nll, r=cjgillot Give name if anonymous region appears in impl signature Fixes rust-lang#98170 We probably should remove the two unwraps in [`report_general_error`](https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_borrowck/diagnostics/region_errors.rs.html#683-685), but I have no idea what to provide if those regions are missing, so I've kept those in. Let me know if I should try harder to remove those.
…=estebank Greatly improve error reporting for futures and generators in `note_obligation_cause_code` Most futures don't go through this code path, because they're caught by `maybe_note_obligation_cause_for_async_await`. But all generators do, and `maybe_note` is imperfect and doesn't catch all futures. Improve the error message for those it misses. At some point, we may want to consider unifying this with the code for `maybe_note_async_await`, so that `async_await` notes all parent constraints, and `note_obligation` can point to yield points. But both functions are quite complicated, and it's not clear to me how to combine them; this seems like a good incremental improvement. Helps with rust-lang#97332. r? ``@estebank`` cc ``@eholk`` ``@compiler-errors``
…t-res, r=petrochenkov Provide a `PathSegment.res` in more cases I find that in many cases, the `res` associated with a `PathSegment` is `Res::Err` even though the path was fully resolved. A few diagnostics use this `res` and their error messages suffer because of the lack of resolved segment. This fixes it a bit, but it's obviously not complete and I'm not exactly sure if it's correct.
…struct-literal, r=compiler-errors Point at private fields in struct literal closes rust-lang#95872
prohibit_generics: don't alloc error string if no error emitted Noticed unreaded allocs in DHAT.
…umeGomez rustdoc: optimize loading of source sidebar The source sidebar has a setting to remember whether it should be open or closed. Previously, this setting was handled in source-script.js, which is loaded with `defer`, meaning it is often run after the document is rendered. Since CSS renders the source sidebar as closed by default, changing this after the initial render results in a relayout. Instead, handle the setting in storage.js, which is the first script to load and is the only script that blocks render. This avoids a relayout and means navigating between files with the sidebar open is faster. Demo: https://rustdoc.crud.net/jsha/defer-source-sidebar/src/alloc/ffi/c_str.rs.html r? ````@GuillaumeGomez````
…=davidtwco Migrate two diagnostics from the `rustc_builtin_macros` crate Migrate two diagnostics to use the struct derive and be translatable. r? ```@davidtwco```
…etrochenkov Update no_default_libraries handling for emscripten target ```@sbc100``` says: > `-sDEFAULT_LIBRARY_FUNCS_TO_INCLUDE=[]` is almost certainly wrong/out-of-date. This setting defaults to the empty list anyway these days so its redundant. Also we now support `-nodefaultlibs` so you can use that, as with other toolchains. rust-lang#98303 (comment)
clarify Arc::clone overflow check comment I had to read this twice to realize that this is explaining that the code is technically unsound, so move that into a dedicated paragraph and make the wording a bit more explicit.
…view-comments, r=eholk Address review comments from rust-lang#98259 It got approved so fast I didn't have time to make changes xD r? ``@eholk``
implement `iter_projections` function on `PlaceRef` this makes the api more flexible. the original function now calls the PlaceRef version to avoid duplicating the code.
…, r=notriddle Fixes handling of keywords in rustdoc json output Fixes rust-lang#98002. Instead of panicking, we just filter them out. cc ```@matthiaskrgr``` r? ```@notriddle```
…=Mark-Simulacrum triagebot.toml: Allow applying nominated labels
Update books ## reference 6 commits in 683bfe5cd64d589c6a1645312ab5f93b6385ccbb..9fce337a55ee4a4629205f6094656195cecad231 2022-05-27 11:54:20 -0700 to 2022-06-22 13:59:28 -0700 - Remove outdated restriction on recursive types (rust-lang/reference#1231) - Clarify "string continue" for (byte) string literals (rust-lang/reference#1042) - Add a note to the turbofish section about impl Trait (rust-lang/reference#1212) - modify confusing variance example (rust-lang/reference#1224) - Add stable references of `macro_metavar_expr` (rust-lang/reference#1192) - Document native library modifier `bundle` (rust-lang/reference#1210) ## book 33 commits in 396fdb69de7fb18f24b15c7ad13491b1c1fa7231..efbafdba3618487fbc9305318fcab9775132ac15 2022-06-08 10:02:35 -0400 to 2022-06-19 21:06:50 -0400 - Propagate tech review edits to appendices to src - Tech review comments and further edits to the appendices - Duplicate fragment "mutation and borrowing" - Propagate ch20 tech review edits to src - Edits in response to tech review of chapter 20 - Comments from tech review on chapter 20 - Propagate ch7 tech review edits to src - Responding to tech review of ch7 - Tech review comments on ch7 - Propagate ch19 tech review edits to src - Responses to tech review of ch19 - Tech review comments on ch 19 - Update ch03-01-variables-and-mutability.md - Add more explanation to CONTRIBUTING about the nostarch directory - Duplicate sentence - Missing period - Regenerate ch09-02 error messages - Change some print formatting styles in ch18 - Propagate tech review ch18 edits to src - Responses to tech review comments of chapter 18 - Chapter 18 from tech review - Snapshot of introduction for nostarch - Propagate edits of ch1 to src - Edits to edits to chapter 1 - Edits from nostarch for chapter 1 - Update Visual Studio instructions for 2022 - bugfix/typo-ch10-01 Fix typo in chapter ch10-01 - Tweak rustfmt slightly for these listings - Propagate edits to ch13 to src - Responses to nostarch edits to ch13 - Edits to ch13 from nostarch - Apply complex Clippy recommendation - Apply Clippy recommendations: `cargo clippy --fix` ## rust-by-example 4 commits in dbb7e5e2345ee26199ffba218156b6009016a20c..1095df2a5850f2d345fad43a30633133365875ba 2022-06-02 16:30:51 -0300 to 2022-06-18 21:47:12 -0300 - Add example for `array.get()` (rust-lang/rust-by-example#1554) - Example improvements (rust-lang/rust-by-example#1552) - Fix for a set of typos (rust-lang/rust-by-example#1551) - Make guard examples clearer around `_` (rust-lang/rust-by-example#1550) ## rustc-dev-guide 11 commits in 6e4d6435db89bcc027b1bba9742e4f59666f5412..048d925f0a955aac601c4160c0e7f05771bcf63b 2022-06-08 08:06:32 +0900 to 2022-06-21 22:25:34 +0900 - not obvious what Ex is, so rather get rid (rust-lang/rustc-dev-guide#1372) - small improves (rust-lang/rustc-dev-guide#1371) - make clear that other versions can work (rust-lang/rustc-dev-guide#1373) - Fix small `src/diagnostics.md` typo (rust-lang/rustc-dev-guide#1370) - Add an "is" and rearange "We next" to "Next, we" (rust-lang/rustc-dev-guide#1369) - diagnostics: add translation documentation - diagnostics: line wrapping/heading changes - later -> latter - Remove mention of -Zborrowck=mir with Polonius. (rust-lang/rustc-dev-guide#1367) - Remove nll compare mode. (rust-lang/rustc-dev-guide#1366) - add section on user types (rust-lang/rustc-dev-guide#1359) ## embedded-book 1 commits in cbb494f96da3268c2925bdadc65ca83d42f2d4ef..e17dcef5e96346ee3d7fa56820ddc7e5c39636bc 2022-05-26 06:58:43 +0000 to 2022-06-19 10:28:00 +0000 - Fix a typo (rust-embedded/book#319)
…te, r=Dylan-DPC Update browser-ui-test version to 0.9.6 This update provides a better error message when chromium crashes. cc ``@jsha`` r? ``@Dylan-DPC``
rustbot
added
T-compiler
|
@bors r+ rollup=never p=16 |
|
📌 Commit c9b1674 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Jun 24, 2022
|
Finished benchmarking commit (e605a88): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Footnotes |
|
This is a really large rollup with lots of changes that could, in theory, impact performance. Please make sure to keep rollups small and only include as few changes as possible that may introduce performance changes (even if this is unlikely). Given the difficulty of investigation and the relatively small magnitude of the regression, I'm going to mark this as triaged. @rustbot label: +perf-regression-triaged |
rustbot
added
the
perf-regression-triaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
with_capacityandreservefamilies of methods #96173 (Fix documentation forwith_capacityandreservefamilies of methods)note_obligation_cause_code#98259 (Greatly improve error reporting for futures and generators innote_obligation_cause_code)PathSegment.resin more cases #98269 (Provide aPathSegment.resin more cases)rustc_builtin_macroscrate #98353 (Migrate two diagnostics from therustc_builtin_macroscrate)note_obligation_cause_code#98259)iter_projectionsfunction onPlaceRef#98388 (implementiter_projectionsfunction onPlaceRef)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup