Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #98537

Closed
wants to merge 29 commits into from

Commits on May 18, 2022

  1. Configuration menu
    Copy the full SHA
    fd76552 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. std: fix deadlock in Parker

    joboet committed May 19, 2022
    Configuration menu
    Copy the full SHA
    3b6ae15 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2022

  1. Configuration menu
    Copy the full SHA
    b9660de View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. Configuration menu
    Copy the full SHA
    5823d7b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    69e8e7e View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. std: relax memory orderings in Parker

    Co-authored-by: Tomoaki Kawada <kawada@kmckk.co.jp>
    joboet and kawadakk committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    caff723 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Configuration menu
    Copy the full SHA
    cc4f804 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3eb9e1a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e4b2b41 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. macros: use typed identifiers in diag derive

    Using typed identifiers instead of strings with the Fluent identifier
    enables the diagnostic derive to benefit from the compile-time
    validation that comes with typed identifiers - use of a non-existent
    Fluent identifier will not compile.
    
    Signed-off-by: David Wood <david.wood@huawei.com>
    davidtwco committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    99bc979 View commit details
    Browse the repository at this point in the history
  2. macros: use typed identifiers in subdiag derive

    As in the diagnostic derive, using typed identifiers in the
    subdiagnostic derive improves the diagnostics of using the subdiagnostic
    derive as Fluent messages will be confirmed to exist at compile-time.
    
    Signed-off-by: David Wood <david.wood@huawei.com>
    davidtwco committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    abd3467 View commit details
    Browse the repository at this point in the history
  3. errors: remove diagnostic message ctors

    Now that typed identifiers are used in both derives, constructors for
    the `DiagnosticMessage` and `SubdiagnosticMessage` types are not
    required.
    
    Signed-off-by: David Wood <david.wood@huawei.com>
    davidtwco committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    dc90d1d View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2022

  1. Configuration menu
    Copy the full SHA
    7475867 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dc2cc10 View commit details
    Browse the repository at this point in the history
  3. bless remaining tests

    RalfJung committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    af58692 View commit details
    Browse the repository at this point in the history
  4. Support setting file accessed/modified timestamps

    Add `struct FileTimes` to contain the relevant file timestamps, since
    most platforms require setting all of them at once. (This also allows
    for future platform-specific extensions such as setting creation time.)
    
    Add `File::set_file_time` to set the timestamps for a `File`.
    
    Implement the `sys` backends for UNIX, macOS (which needs to fall back
    to `futimes` before macOS 10.13 because it lacks `futimens`), Windows,
    and WASI.
    joshtriplett committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    24b66da View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e2b5729 View commit details
    Browse the repository at this point in the history
  6. bless after rebase

    RalfJung committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    3899914 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2022

  1. Return an error if trying to set a file timestamp to 0 on Windows

    This would otherwise silently ignore the attempt, since 0 serves as a
    flag to not set a timestamp.
    joshtriplett committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    1d32fed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2339bb2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0398aa8 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#97140 - joboet:solid_parker, r=m-ou-se

    std: use an event-flag-based thread parker on SOLID
    
    `Mutex` and `Condvar` are being replaced by more efficient implementations, which need thread parking themselves (see rust-lang#93740). Therefore, the generic `Parker` needs to be replaced on all platforms where the new lock implementation will be used, which, after rust-lang#96393, are SOLID, SGX and Hermit (more PRs coming soon).
    
    SOLID, conforming to the [μITRON specification](http://www.ertl.jp/ITRON/SPEC/FILE/mitron-400e.pdf), has event flags, which are a thread parking primitive very similar to `Parker`. However, they do not make any atomic ordering guarantees (even though those can probably be assumed) and necessitate a system call even when the thread token is already available. Hence, this `Parker`, like the Windows parker, uses an extra atomic state variable.
    
    I future-proofed the code by wrapping the event flag in a `WaitFlag` structure, as both SGX and Hermit can share the Parker implementation, they just have slightly different primitives (SGX uses signals and Hermit has a thread blocking API).
    
    ```@kawadakk``` I assume you are the target maintainer? Could you test this for me?
    matthiaskrgr committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    03edb85 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#97295 - c410-f3r:yet-another-let-chain, r=c…

    …ompiler-errors
    
    [rustc_parse] Forbid `let`s in certain places
    
    Currently only forbids in locals to resolve rust-lang#94927 (comment) but feel free to point any other places.
    matthiaskrgr committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    8df0f4a View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#97743 - RalfJung:const-err-future-breakage,…

    … r=estebank
    
    make const_err show up in future breakage reports
    
    As tracked in rust-lang#71800, const_err should become a hard error Any Day Now (TM). I'd love to move forward with that sooner rather than later; it has been deny-by-default for many years and a future incompat lint since rust-lang#80394 (landed more than a year ago). Some CTFE errors are already hard errors since rust-lang#86194. But before we truly make it a hard error in all cases, we now have one more intermediate step we can take -- to make it show up in future breakage reports.
    
    Cc ```@rust-lang/wg-const-eval```
    matthiaskrgr committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    3fb4a87 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#97908 - iago-lito:stabilize_nonzero_checked…

    …_ops_constness, r=scottmcm
    
    Stabilize NonZero* checked operations constness.
    
    Partial stabilization for rust-lang#97547 (continued).
    matthiaskrgr committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    f8e3771 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#98246 - joshtriplett:times, r=m-ou-se

    Support setting file accessed/modified timestamps
    
    Add `struct FileTimes` to contain the relevant file timestamps, since
    most platforms require setting all of them at once. (This also allows
    for future platform-specific extensions such as setting creation time.)
    
    Add `File::set_file_time` to set the timestamps for a `File`.
    
    Implement the `sys` backends for UNIX, macOS (which needs to fall back
    to `futimes` before macOS 10.13 because it lacks `futimens`), Windows,
    and WASI.
    matthiaskrgr committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    b843ac5 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#98297 - GuillaumeGomez:help-pocket-menu, r=…

    …notriddle
    
    Transform help popup into a pocket menu
    
    Just like we moved the settings menu into a "pocket menu", it's doing the same to the help popup.
    
    You can test it [here](https://rustdoc.crud.net/imperio/help-pocket-menu/doc/foo/index.html) and here is a screenshot:
    
    ![Screenshot from 2022-06-20 20-58-29](https://user-images.githubusercontent.com/3050060/174663718-538e9d11-3bf9-48b2-8909-f9bfe75af135.png)
    
    r? ````````@jsha````````
    matthiaskrgr committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    4b59173 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#98428 - davidtwco:translation-derive-typed-…

    …identifiers, r=oli-obk
    
    macros: use typed identifiers in diag and subdiag derive
    
    Using typed identifiers instead of strings with the Fluent identifiers in the diagnostic and subdiagnostic derives - this enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers, namely that use of a non-existent Fluent identifier will not compile.
    
    r? ```@oli-obk```
    matthiaskrgr committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    14859a5 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#98535 - GuillaumeGomez:regression-test-9285…

    …9, r=lcnr
    
    Add regression test for generic const in rustdoc
    
    Fixes rust-lang#92859.
    
    r? `@lcnr`
    matthiaskrgr committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    45f9740 View commit details
    Browse the repository at this point in the history