Adding suggestion for E0530 #99008
Merged
Adding suggestion for E0530 #99008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @compiler-errors (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
You need to check if a test exists for the same error code as well and update that |
|
Shouldn't this note be emitted for any tuple variants in patterns that lack parentheses? Why special-case |
|
I agree that I don't think this should be special cased, and that it needs a test. Feel free to ping me when these are fixed! @rustbot author |
rustbot
added
S-waiting-on-author
obeis
changed the title
This comment has been minimized.
This comment has been minimized.
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
compiler-errors
approved these changes
Jul 8, 2022
|
@obeis, this PR is already approved and enqueued to land. Not sure why you pinged me? |
|
Just by wrong, thank you for approving this pull request :) |
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 9, 2022
Adding suggestion for E0530 Closes rust-lang#98974
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 9, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#98350 (Implement support for DWARF version 5.) - rust-lang#98915 (Clarify deriving code) - rust-lang#98980 (fix ICE in ConstProp) - rust-lang#99008 (Adding suggestion for E0530) - rust-lang#99043 (Collapse some weirdly-wrapping derives) - rust-lang#99048 (Remove a string comparison about types) - rust-lang#99070 (Update integer_atomics tracking issue) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #98974