Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update integer_atomics tracking issue #99070

Merged
merged 1 commit into from
Jul 9, 2022
Merged

Update integer_atomics tracking issue #99070

merged 1 commit into from
Jul 9, 2022

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Jul 8, 2022

Updates #32976.
Updates #99069.

r? @RalfJung

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 8, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jul 8, 2022

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 8, 2022
@RalfJung
Copy link
Member

RalfJung commented Jul 9, 2022

I am confused, why this and what do I have to do with it?^^

@RalfJung
Copy link
Member

RalfJung commented Jul 9, 2022

Oh I see... that was >2 weeks ago, I had forgotten about it.^^
@bors r+ rollup

In the tracking issue, it'd be good to list the APIs that are covered by that tracking issue, and copy any open questions that have been noted in the RFC of the previous tracking issue.

@bors
Copy link
Contributor

bors commented Jul 9, 2022

📌 Commit a491d45 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 9, 2022
@Dylan-DPC
Rollup merge of rust-lang#99070 - tamird:update-tracking-issue, r=Ral…
6816a8d 
…fJung

Update integer_atomics tracking issue

Updates rust-lang#32976.
Updates rust-lang#99069.

r? `@RalfJung`
This was referenced Jul 9, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 9, 2022
@bors
Auto merge of rust-lang#99078 - Dylan-DPC:rollup-gnw6cli, r=Dylan-DPC
c4693bc 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#98350 (Implement support for DWARF version 5.)
 - rust-lang#98915 (Clarify deriving code)
 - rust-lang#98980 (fix ICE in ConstProp)
 - rust-lang#99008 (Adding suggestion for E0530)
 - rust-lang#99043 (Collapse some weirdly-wrapping derives)
 - rust-lang#99048 (Remove a string comparison about types)
 - rust-lang#99070 (Update integer_atomics tracking issue)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3c35da2 into rust-lang:master Jul 9, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 9, 2022
@tamird tamird deleted the update-tracking-issue branch July 9, 2022 11:04
JohnTitor pushed a commit to JohnTitor/rust that referenced this pull request Jul 26, 2022
@Dylan-DPC
Rollup merge of rust-lang#99070 - tamird:update-tracking-issue, r=Ral…
e151a09 
…fJung

Update integer_atomics tracking issue

Updates rust-lang#32976.
Updates rust-lang#99069.

r? ``@RalfJung``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RalfJung RalfJung

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tamird @rustbot @RalfJung @bors @rust-highfive