Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #99726

Closed
wants to merge 20 commits into from
Closed

Commits on Jun 30, 2022

  1. Configuration menu
    Copy the full SHA
    6c3ca7e View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2022

  1. Configuration menu
    Copy the full SHA
    f6247ff View commit details
    Browse the repository at this point in the history
  2. add a concrete example

    RalfJung committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    2e0ca94 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2022

  1. typo

    Co-authored-by: Ben Kimock <kimockb@gmail.com>
    RalfJung and saethlin committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    eed5df5 View commit details
    Browse the repository at this point in the history
  2. remove a dubious example

    RalfJung committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    1b3870e View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2022

  1. Configuration menu
    Copy the full SHA
    9fc5463 View commit details
    Browse the repository at this point in the history
  2. Add issue numbers

    fee1-dead committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    a89510e View commit details
    Browse the repository at this point in the history
  3. add const hack comment

    fee1-dead committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    65fca6d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f80bf10 View commit details
    Browse the repository at this point in the history
  5. Implement fs::get_path for FreeBSD.

    Using `F_KINFO` fcntl flag, the kf_structsize field
    needs to be set beforehand for that effect.
    devnexen committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    5803492 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2022

  1. Remove reachable coverage without counters

    Remove reachable coverage without counters to maintain invariant that
    either there is no coverage at all or there is a live coverage counter
    left that provides the function source hash.
    
    The motivating example would be a following closure:
    
    ```rust
        let f = |x: bool| {
            debug_assert!(x);
        };
    ```
    
    Which, with span changes from rust-lang#93967, with disabled debug assertions,
    after the final CFG simplifications but before removal of dead blocks,
    gives rise to MIR:
    
    ```rust
    fn main::{closure#0}(_1: &[closure@a.rs:2:13: 2:22], _2: bool) -> () {
        debug x => _2;
        let mut _0: ();
    
        bb0: {
            Coverage::Expression(4294967295) = 1 - 2;
            return;
        }
    
        ...
    }
    ```
    tmiasko committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    5f40a4f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bf1a5e7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    051e98b View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#92390 - fee1-dead-contrib:const_cmp, r=oli-obk

    Constify a few `(Partial)Ord` impls
    
    Only a few `impl`s are constified for now, as rust-lang#92257 has not landed in the bootstrap compiler yet and quite a few impls would need that fix.
    
    This unblocks rust-lang#92228, which unblocks marking iterator methods as `default_method_body_is_const`.
    Dylan-DPC committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    5509e42 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#98211 - devnexen:get_path_freebsd, r=Mark-S…

    …imulacrum
    
    Implement `fs::get_path` for FreeBSD.
    
    Using `F_KINFO` fcntl flag, the kf_structsize field
    needs to be set beforehand for that effect.
    Dylan-DPC committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    6e28b0e View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#98710 - mojave2:string, r=JohnTitor

    correct the output of a `capacity` method example
    
    The output of this example in std::alloc is different from which shown in the comment. I have tested it on both Linux and Windows.
    Dylan-DPC committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    c0893e9 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#99084 - RalfJung:write_bytes, r=thomcc

    clarify how write_bytes can lead to UB due to invalid values
    
    Fixes rust-lang/unsafe-code-guidelines#330
    
    Cc `@5225225`
    Dylan-DPC committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    5d015ae View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#99673 - RalfJung:interpret-invalid-dyn, r=o…

    …li-obk
    
    don't ICE on invalid dyn calls
    
    Due to rust-lang#50781 this is actually reachable.
    Fixes rust-lang/miri#2432
    
    r? `@oli-obk`
    Dylan-DPC committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    f3bf936 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#99711 - tmiasko:coverage, r=wesleywiser

    Remove reachable coverage without counters
    
    Remove reachable coverage without counters to maintain invariant that
    either there is no coverage at all or there is a live coverage counter
    left that provides the function source hash.
    
    The motivating example would be a following closure:
    
    ```rust
        let f = |x: bool| {
            debug_assert!(x);
        };
    ```
    
    Which, with span changes from rust-lang#93967, with disabled debug assertions,
    after the final CFG simplifications but before removal of dead blocks,
    gives rise to MIR:
    
    ```rust
    fn main::{closure#0}(_1: &[closure@a.rs:2:13: 2:22], _2: bool) -> () {
        debug x => _2;
        let mut _0: ();
    
        bb0: {
            Coverage::Expression(4294967295) = 1 - 2;
            return;
        }
    
        ...
    }
    ```
    
    Which also makes the initial instrumentation quite suspect, although
    this pull request doesn't attempt to address that aspect directly.
    
    Fixes rust-lang#98833.
    
    r? `@wesleywiser` `@richkadel`
    Dylan-DPC committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    0d25480 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#99718 - TaKO8Ki:avoid-&str-symbol-to-string…

    …-conversions, r=michaelwoerister
    
    Avoid `&str`/`Symbol` to `String` conversions
    
    follow-up to rust-lang#99342 and rust-lang#98668
    Dylan-DPC committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    6cba515 View commit details
    Browse the repository at this point in the history