Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf triage 2020-08-31 #756

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

ecstatic-morse
Copy link
Contributor


#### Nags requiring follow up

None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to follow-up on the regression to make sure we're not missing a bunch of wine (i.e. if it's coincidental that the two PRs have similar effects).

Copy link
Contributor Author

@ecstatic-morse ecstatic-morse Sep 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already left a comment on the regressed PR, but given this comment I'm pretty sure we won't need to nag anybody.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, great, ok.

@Mark-Simulacrum Mark-Simulacrum merged commit 3d422f9 into rust-lang:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants