Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate rustfmt into multiple crates #3998

Merged
merged 18 commits into from
Jan 5, 2020
Merged

Separate rustfmt into multiple crates #3998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f1846ed
Separate rustfmt-core
topecongiro Jan 4, 2020
7d9d5c5
Separate rustfmt-config
topecongiro Jan 4, 2020
ca0be26
Clean up
topecongiro Jan 4, 2020
a140df6
Separate rustfmt-emitter
topecongiro Jan 4, 2020
3ca3cbb
Use workspace
topecongiro Jan 4, 2020
507a704
Add back generic-simd feature
topecongiro Jan 4, 2020
007e34a
Bump versions
topecongiro Jan 4, 2020
8889c94
Bump versions
topecongiro Jan 4, 2020
36a097b
Update Cargo.toml
topecongiro Jan 4, 2020
7a51340
Rename rustfmt_config to rustfmt_configuration
topecongiro Jan 4, 2020
9d08fe8
Update Cargo.toml
topecongiro Jan 4, 2020
672ac87
Update Cargo.toml
topecongiro Jan 4, 2020
8dc5baa
Update Cargo.toml
topecongiro Jan 4, 2020
f749269
Update Cargo.toml
topecongiro Jan 4, 2020
eac32dd
Use the pathced ignore crate
topecongiro Jan 4, 2020
2d32496
Rename libs
topecongiro Jan 4, 2020
c51a44d
Fix CI
topecongiro Jan 4, 2020
50376e6
Remove auto-generated comment from Cargo.toml
topecongiro Jan 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 6 additions & 0 deletions .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,9 @@ jobs:
- name: 'test ignored'
run: cargo test -- --ignored
shell: cmd
- name: 'test rustfmt-core'
run: cargo test --manifest-path rustfmt-core/Cargo.toml
shell: cmd
- name: 'test rustfmt-core ignored'
run: cargo test --manifest-path rustfmt-core/Cargo.toml -- --ignored
shell: cmd
Copy link
Member

@calebcartwright calebcartwright Jan 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another enhacement we could consider making with GHA in the future would be to set up some additional workflows that have directory/crate specific triggers. As an example, if the only changes are to the emitter crate, our CI will only have to build the emitter crate

2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ matrix:
script:
- |
if [ -z ${INTEGRATION} ]; then
cargo build && cargo test && cargo test -- --ignored
cargo build && cargo test && cargo test -- --ignored && cargo test --manifest-path rustfmt-core/Cargo.toml && cargo test --manifest-path rustfmt-core/Cargo.toml -- --ignored
else
./ci/integration.sh
fi
Expand Down
Loading