Separate rustfmt into multiple crates #3998
Conversation
|
Awesome! One big step closer to rustfmt 2.x! Regarding the patched version of |
| shell: cmd | ||
| - name: 'test rustfmt-core ignored' | ||
| run: cargo test --manifest-path rustfmt-core/Cargo.toml -- --ignored | ||
| shell: cmd |
There was a problem hiding this comment.
Another enhacement we could consider making with GHA in the future would be to set up some additional workflows that have directory/crate specific triggers. As an example, if the only changes are to the emitter crate, our CI will only have to build the emitter crate
| @@ -0,0 +1,53 @@ | |||
| [package] | |||
| name = "rustfmt_lib" | |||
| version = "1.0.0" | |||
There was a problem hiding this comment.
What'd you have in mind for versioning strategy between these different crates and the main rustfmt bin folks will get via rustup? Will they each be versioned independently, should the lib and bin versions be kepty in sync, etc.?
There was a problem hiding this comment.
The crates in rustfmt-core will be versioned differently from binaries (e.g., rustfmt 3.0 may depend on rustfmt-core 4.0, rustfmt-emitter 2.0, and rustfmt-configuration 3.0).
rustfmt-core/rustfmt-lib/Cargo.toml
Outdated
| license = "Apache-2.0/MIT" | ||
| repository = "https://github.com/rust-lang/rustfmt" | ||
|
|
||
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html |
There was a problem hiding this comment.
Can probably remove the cargo-generated lines like this right?
There was a problem hiding this comment.
Yeah, you are right. Good catch, thank you!
topecongiro
force-pushed
the
rustfmt-core
branch
from
96223cd
to
50376e6
Compare
Yes, using rustfmt-ignore is a temporal workaround. |
|
FYI, |
|
Awesome, thanks @BurntSushi! |
|
backport not needed (I think) |
This PR separates rustfmt into multiple crates:
Since rustfmt is registered as a workspace member in the rustc repository, we cannot directly use the workspace in rustfmt. As such, we put the above crates under the rustfmt-core directory.
Unnecessarily amount of commits shows my struggle trying to publish workspace members to crates.io and to patch
ignorecrate 🤷♂️ Sorry about that!