Arm Fused Multiply-Add fixes #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
hkratz
force-pushed
the
require_vfp4_instead_of_v8_for_fma
branch
2 times, most recently
from
6b91a5f
to
12d2c24
Compare
|
Inlining check disabled again. The new cc @SparrowLii |
Some VFMA functions have `target_feature(enable = "vfp4")` while the called functions `vdup_n_f32` and `vdupq_n_f32` are `target_feature(enable = "v7")`. LLVM does not inline the functions due to the different feature flags. Using private _vfp4 variants of those functions allows them to be inlined.
hkratz
force-pushed
the
require_vfp4_instead_of_v8_for_fma
branch
from
12d2c24
to
9e33ce7
Compare
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 27, 2021
Update stdarch submodule This is mainly to fix the critical issue of aarch64 store intrinsics overwriting additional memory, see rust-lang/stdarch#1220 Changes: * aarch64/armv7: additional vld1/vst1 intrinsics + perf fixes for existing ones * rust-lang/stdarch#1205 * rust-lang/stdarch#1207 * rust-lang/stdarch#1216 * armv7: Make FMA work with vfpv4 and optimize * rust-lang/stdarch#1219 * Non-visible changes to the testing framework * rust-lang/stdarch#1208 * rust-lang/stdarch#1211 * rust-lang/stdarch#1213 * rust-lang/stdarch#1215 * rust-lang/stdarch#1218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes muliple issues with 32-bit ARM Fused Multiply-Add intrinsics:
vfp4notv8vdup_n_f32andvdupq_n_f32instructions don't have the vfp4 feature enabled. Fixes The assembly emitted for some arm neon fma intrinsics contains function calls #1212.It enables the ARM inlining check for Inlining checks are broken for arm #1210.