Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Remove CallableData from FnItem and use fields instead #194

Merged
merged 2 commits into from
Jul 24, 2023
Merged

API: Remove CallableData from FnItem and use fields instead #194

merged 2 commits into from
Jul 24, 2023

Conversation

xFrednet
Copy link
Member

@xFrednet xFrednet commented Jul 23, 2023 •
edited
Loading

cc: #181

@xFrednet xFrednet added C-enhancement Category: New feature or request A-api Area: Stable API D-rustc-driver Driver: Rustc Driver S-waiting-on-review Status: Awaiting review labels Jul 23, 2023
@xFrednet xFrednet added this to the v0.2.0 milestone Jul 23, 2023
@xFrednet xFrednet mentioned this pull request Jul 23, 2023
Closed
2 tasks
@xFrednet xFrednet force-pushed the 181-parameter-patterns branch from bf46160 to aecdb33 Compare July 23, 2023 14:50
@xFrednet xFrednet force-pushed the 181-parameter-patterns branch from aecdb33 to dc36889 Compare July 23, 2023 17:14
@xFrednet
Copy link
Member Author

I'm merging this in preparation for the next PR :)

bors r

@xFrednet
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Jul 24, 2023
@bors @xFrednet
Merge #194
014716f 
194: API: Remove `CallableData` from `FnItem` and use fields instead r=xFrednet a=xFrednet



cc: #181

Co-authored-by: xFrednet <xFrednet@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 24, 2023

Build failed:

@xFrednet xFrednet force-pushed the 181-parameter-patterns branch from dc36889 to 95651b1 Compare July 24, 2023 08:49
@xFrednet
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Jul 24, 2023
@bors @xFrednet
Merge #194
5cae6a4 
194: API: Remove `CallableData` from `FnItem` and use fields instead r=xFrednet a=xFrednet



cc: #181

Co-authored-by: xFrednet <xFrednet@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 24, 2023

Build failed:

@xFrednet xFrednet force-pushed the 181-parameter-patterns branch from 95651b1 to 3a5c5d1 Compare July 24, 2023 09:11
@xFrednet
Copy link
Member Author

Why windows, how drunk were you, when you decided to use \\ as path separators? Who hurt you so much, that you have to terrorize everyone around you with this???

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 24, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 41eaf5b into rust-marker:master Jul 24, 2023
@xFrednet xFrednet deleted the 181-parameter-patterns branch July 24, 2023 09:18
@xFrednet xFrednet mentioned this pull request Sep 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-api Area: Stable API C-enhancement Category: New feature or request D-rustc-driver Driver: Rustc Driver S-waiting-on-review Status: Awaiting review
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@xFrednet