API: Removed the CallableData
trait
#265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CallableData
trait, was designed with the idea to have a general trait for function like things, includingFnItem
,ClosureExpr
,SenFnPrtTy
. However, after working with Marker for a bit, I learned that these AST nodes are just too different. At least, too different, to have theCallableData
trait as the main API.I'm also not sure what the use case would be, where a syntactic type should be handled the same way as a
FnItem
.This PR simply removes the trait and moves the remaining functions to the
SenFnPrtTy
type. #194 already removed the trait fromFnItem
andClosureExpr
.This PR also deletes the
SynClosureTy
since it's not actually a syntactic type that can be written ^^