-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow recreating wasm event loop with spawn
#2897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
You said you still wanted to test this in detail, so I'm gonna hold off merging this until you are ready.
@daxpedda confirmed that it allows me to recreate the event loop, so this should be ready |
628be54
to
6e45230
Compare
Rebased again for the changelog conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This will still need another rebase though, sorry!
EDIT: tried it myself, but your fork is part of an organization, so I don't have access.
6e45230
to
9d86c7c
Compare
@daxpedda thanks! Rebased |
Rebased #2720
CHANGELOG.md
if knowledge of this change could be valuable to usersIt seems to work after rebasing but haven't been able to test in detail yet. It looks like some other recent winit changes broke my canvas sizing so I need to look into that.