Don't allow event loops to run in parallel #2907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grovesNL
approved these changes
Jun 29, 2023
|
I wish this wan't merged. Why is this here? It makes things unnecessarily complicated on the user end. It should be perfectly fine to have multiple event loops running in parallel, running with multiple canvases? |
|
Allowing multiple event loops at the same time will collide with future changes, e.g. #3311. Whats the motivation behind this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently multiple event loops can be run at the same time when using
spawn(), which was not the intention of #2897 and isn't documented as such.Follow up on #2897.
Cc @grovesNL.