Replace most To* traits by Into #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neg fallout - 2
Allow writing `matrix * scalar`
Bump version
Fixed the num crate
…e. Benching is unstable and therefore only available on nightly; removed from travis in the interim.
|
👍 |
|
Don't merge. Once #215 is merged, I'll rebase this one and resubmit it. |
Merge the rust-1.0 branch into master
…e. Benching is unstable and therefore only available on nightly; removed from travis in the interim.
|
Closing for #216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[breaking-change]
Instead of having 10 different traits (
ToQuaternion,ToMatrix4,ToRad, etc.), use a single one:Into. TheIntotrait is in the prelude.The next step would be to modify some definitions to take a
Into<F>instead of directly aF.The from_fixed/into_fixed functions would also need to be converted.