-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace most To* traits by Into #216
Conversation
I'm good with it. Calling for @cmr @bjz @csherratt to look as well. |
I don't have any large objections, just one question is there a way to do this without the the extra assignment? // maybe?
angle.into::<Deg<_>>(); Just don't want to break the ability to write one liners. |
I think you can write But the major idea is that for example functions that take a For example if we add |
Freaken awesome tomaka! So |
In fact you can just write |
I guess @csherratt is good with the change. Merging now. |
Next version to be published should have its minor version bumped! |
Looks like this never made it into the docs (docs still refer to ToMatrix4 etc.) Awesome lib btw! Looks very well written |
See #214