Fix UB in Windows verifier EKU handling #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, ensure we only pass thin string pointers, not fat ones
complexspaces
added
bug
djc
approved these changes
Aug 23, 2024
ctz
reviewed
Aug 23, 2024
ctz
approved these changes
Aug 23, 2024
ctz
approved these changes
Aug 23, 2024
djc
reviewed
Aug 23, 2024
| @@ -82,8 +82,11 @@ fn invalid_certificate(reason: impl Into<String>) -> rustls::Error { | |||
| /// - id-kp-serverAuth | |||
| // TODO: Chromium also allows for `OID_ANY_EKU` on Android. | |||
| #[cfg(target_os = "windows")] | |||
| // XXX: Windows requires that we NUL terminate EKU strings and we want to make sure that only the | |||
There was a problem hiding this comment.
I think this sentence is missing a word. Otherwise LGTM!
There was a problem hiding this comment.
Oops, good catch. I'll fix this when migrating to windows_sys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements two fixes in the Windows verifier to fix UB and future-UB:
NULL-terminate the EKU strings we pass in.See the linked issue for a more detailed analysis if you're curious why this was never problematic before.
Closes #126