Take test fixes for 0.1 release branch, and prepare 0.1.2 #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is definitely not happy with the outdated Android image and new* clippy lints 😢 |
Merged
lol, please excuse the noise while I determine the precise set of testing/infra commits to cherry pick... |
Fixing the `SystemTime` that we pass to the certificate verifier for the mock and real world verification tests will ensure that the tests don't start to fail just because the vendored certificates have expired.
* Updates the test cert for presently unknown reasons the previous EE cert is returning an error in the Android real world verification test suite that appears resolved by refreshing the EE cert. * Updates the mock verification timestamp to be newer than the LE EE cert's NotBefore date.
The existing copy expired yesterday. Along with updating the cert the fixed verification time is updated so that we avoid a not-yet-valid error from the updated cert's NotBefore date being newer than the previous fixed verification time.
* Runs `update_valid_ee_certs.rs`, committing the two updated `.crt` files that result. * Updates the `verification_time()` to the current time to avoid not before errors.
Commits the result of running `src/tests/verification_mock/ca.go`. The `root1.crt` CA and intermediate expired and were breaking tests in CI.
Fixes clippy findings of the form: ``` error: doc list item missing indentation --> rustls-platform-verifier/src/tests/verification_real_world/mod.rs:17:5 | 17 | //! with the measures mentioned in the next paragraphs, the operating system | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `-D clippy::doc-lazy-continuation` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::doc_lazy_continuation)]` ```
Previously the Android emulator based CI job was using the larger `googles_api` target instead of the slimmer default. This was done to ensure network access worked as intended for the real-world test suite with a TODO to revisit after an upstream bug was fixed. In the meantime the upstream bug has been closed and we've upgraded the emulator action version. Let's try the default target again and hopefully get a small CI speedup.
Bumps [reactivecircus/android-emulator-runner](https://github.com/reactivecircus/android-emulator-runner) from 2.30.1 to 2.31.0. - [Release notes](https://github.com/reactivecircus/android-emulator-runner/releases) - [Changelog](https://github.com/ReactiveCircus/android-emulator-runner/blob/main/CHANGELOG.md) - [Commits](ReactiveCircus/android-emulator-runner@6b0df4b...77986be) --- updated-dependencies: - dependency-name: reactivecircus/android-emulator-runner dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [reactivecircus/android-emulator-runner](https://github.com/reactivecircus/android-emulator-runner) from 2.31.0 to 2.32.0. - [Release notes](https://github.com/reactivecircus/android-emulator-runner/releases) - [Changelog](https://github.com/ReactiveCircus/android-emulator-runner/blob/main/CHANGELOG.md) - [Commits](ReactiveCircus/android-emulator-runner@77986be...f0d1ed2) --- updated-dependencies: - dependency-name: reactivecircus/android-emulator-runner dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
This avoids using a rustls version with a known vulnerability.
|
ok, whew. ready for review. all but the final two commits are already on main. |
|
FWIW in the future I can handle the bulk of I'll take a look at the changes here either way though 👍 |
complexspaces
approved these changes
Aug 23, 2024
|
Can I leave you to merge this and make the release? |
|
Sure, I'd be happy to handle that. Thanks for getting the branch caught up in CI. |
Post-merge steps
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the tail end of #127, plus a version bump, plus test churn commits. That gets
cargo testworking for me locally. Let's see what CI thinks...