Add dataview attribute output to WebIDL Codegen #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some WebIDL specs (WebBluetooth, WebUSB, etc) use DataView as an attribute type. These attributes should map to a js_sys::DataView type. Fixes rustwasm#2312
WebBluetooth has a couple DataView attrs that are required for certain core functionality. These were not being generated when the original patch was landed, but after the DataView fix, they now show up.
qdot
force-pushed
the
webidl-dataview-attrs
branch
from
12f8746
to
0920e2a
Compare
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebBluetooth and some other specs use DataView as an attribute type. Tested against my project using WebBluetooth, seems to work fine (Wrapped resulting buffer in UInt8Array to go to &[u8], everything seems to work). Not sure if there were other tests I need to add here.