Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace curl with ureq #1290

Merged
merged 3 commits into from
May 30, 2023
Merged

Replace curl with ureq #1290

merged 3 commits into from
May 30, 2023

Conversation

ranile
Copy link
Contributor

@ranile ranile commented May 30, 2023

The HTTP client is now pure Rust. This fixes a segfault I was having on my computer

Fixes #1281
Fixes #1234
Fixes #1203
Fixes #1079
Fixes #997
Fixes #650
Fixes #823

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

The HTTP client is now pure Rust
@ranile ranile mentioned this pull request May 30, 2023
3 tasks
ranile added 2 commits May 30, 2023 19:31
also regenerate lockfile to remove curl and friends from Cargo.lock
@ranile
Copy link
Contributor Author

ranile commented May 30, 2023

@drager can we merge this?

Copy link
Member

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@drager drager merged commit 0326141 into rustwasm:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants