Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--no-pack flag #1291

Merged
merged 5 commits into from
May 30, 2023
Merged

--no-pack flag #1291

merged 5 commits into from
May 30, 2023

Conversation

ranile
Copy link
Contributor

@ranile ranile commented May 30, 2023

Update #695, which has been stale for a while.

This is based on top of #1290, which should be merged first.

Closes #695 (supersedes it)
Fixes #691
Fixes #811

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

drager
drager reviewed May 30, 2023
View reviewed changes
tests/all/build.rs Outdated Show resolved Hide resolved
drager
drager approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@drager drager merged commit 031d591 into rustwasm:master May 30, 2023
@ranile ranile mentioned this pull request Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drager drager drager approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-NPM operation of wasm-pack Mini-RFC: --no-pack flag
3 participants
@ranile @drager @ashleygwilliams