-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task: Implement toast based activity indicator #1600 #1747
Conversation
priyonto
commented
Dec 3, 2023
- Replaces old implementation of indicator
Common/RuuviPresenters/Sources/RuuviPresenters/Resources/fr.lproj/RuuviPresenters.strings
Show resolved
Hide resolved
exportService.csvLog(for: ruuviTag.id, settings: sensorSettings) | ||
.on(success: { [weak self] url in | ||
self?.view?.showExportSheet(with: url) | ||
}, failure: { [weak self] (error) in | ||
self?.errorPresenter.present(error: error) | ||
}, completion: { [weak self] in | ||
self?.isLoading = false | ||
self?.activityPresenter.dismiss() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add here dismiss(immediately: true)
} | ||
|
||
public class ActivityPresenterViewProvider: NSObject { | ||
private static let stateHolder = ActivityPresenterStateHolder() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't get why static?
- Replaces old implementation of indicator
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |