Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync status to sensor settings page #1600

Closed
markoaamunkajo opened this issue Aug 21, 2023 · 6 comments
Closed

Sync status to sensor settings page #1600

markoaamunkajo opened this issue Aug 21, 2023 · 6 comments
Labels
4h bug Something isn't working enhancement New feature or request
Milestone
2.6

Comments

@markoaamunkajo
Copy link
Collaborator

markoaamunkajo commented Aug 21, 2023 •
edited
Loading

Description:

Show sync status as toast message on sensor settings page when user is signed in:

Saving to cloud... please wait.
Saved successfully.
Couldn't save changes to cloud.

Use same toast as other errors.

Let's do it for sensor settings page first.

Automatic retry or next app open case: how we tell to user that it got stored, do we need to modify logic somehow?

Android card: ruuvi/com.ruuvi.station#1087
@markoaamunkajo markoaamunkajo added the Spec Needed Requires spec and/or UX/UI design label Aug 21, 2023
@markoaamunkajo markoaamunkajo mentioned this issue Aug 21, 2023
Closed
@markoaamunkajo markoaamunkajo added this to the 2.6 milestone Aug 29, 2023
@markoaamunkajo markoaamunkajo added enhancement New feature or request and removed Spec Needed Requires spec and/or UX/UI design labels Sep 7, 2023
@priyonto priyonto added 8h 16h and removed 8h labels Sep 25, 2023
@markoaamunkajo markoaamunkajo changed the title Sync status icon to sensor settings page Sync status to sensor settings page Oct 17, 2023
priyonto added a commit that referenced this issue Dec 3, 2023
@priyonto
task: Implement toast based activity indicator #1600
d04b5e1 
- Replaces old implementation of indicator
priyonto added a commit that referenced this issue Dec 6, 2023
@priyonto
fixup! task: Implement toast based activity indicator #1600
3e650f2 
Refactor and improvement of code
priyonto added a commit that referenced this issue Dec 6, 2023
@priyonto
task: Implement toast based activity indicator #1600
3500e76 
- Replaces old implementation of indicator
priyonto added a commit that referenced this issue Dec 6, 2023
@priyonto
Merge pull request #1747 from ruuvi/task/1600-1
df1ad18 
task: Implement toast based activity indicator #1600
priyonto added a commit that referenced this issue Dec 12, 2023
@priyonto
feature: Show cloud saving state on sensor settings #1600
4625f1d
priyonto added a commit that referenced this issue Dec 12, 2023
@priyonto
feature: Show cloud saving state on sensor settings #1600
1ddaf5f
priyonto added a commit that referenced this issue Dec 12, 2023
@priyonto
Merge pull request #1770 from ruuvi/feature/1600
085016a 
feature: Show cloud saving state on sensor settings #1600
@rinat-enikeev rinat-enikeev mentioned this issue Dec 12, 2023
Merged
@priyonto priyonto assigned markoaamunkajo and unassigned priyonto Dec 12, 2023
@markoaamunkajo
Copy link
Collaborator Author

@priyonto looks like there is "correct" checkmark being used for unsuccessful saving. Let's use "cross mark" checkmark instead ❌

Couldnt_save.mov

@markoaamunkajo markoaamunkajo added the bug Something isn't working label Dec 13, 2023
priyonto added a commit that referenced this issue Dec 13, 2023
@priyonto
fix: Incorrect icon for failed events on sensor settings #1600
4526c39
priyonto added a commit that referenced this issue Dec 13, 2023
@priyonto
fix: Incorrect icon for failed events on sensor settings #1600 (#1774)
c146f8b
@priyonto priyonto added 4h and removed 16h labels Dec 18, 2023
priyonto added a commit that referenced this issue Dec 21, 2023
@priyonto
fix: Fix UI glitch after toast is dismissed #1600
0bd268d 
Increase min screen on time for toast to 1.5 seconds from 1 second.
priyonto added a commit that referenced this issue Dec 21, 2023
@priyonto
fix: Fix UI glitch after toast is dismissed #1600 (#1816)
b61ed52 
Increase min screen on time for toast to 1.5 seconds from 1 second.
@priyonto priyonto mentioned this issue Dec 21, 2023
Merged
priyonto added a commit that referenced this issue Dec 21, 2023
@priyonto
fix: Fix UI glitch after toast is dismissed #1600 (#1816) (#1817)
567c245 
Increase min screen on time for toast to 1.5 seconds from 1 second.
@priyonto priyonto assigned markoaamunkajo and unassigned priyonto Dec 21, 2023
@markoaamunkajo
Copy link
Collaborator Author

@priyonto I was still able to make the app freeze when changing alert settings on sensor settings page.
This build is 2.6.0 (2312211201)

priyonto added a commit that referenced this issue Dec 27, 2023
@priyonto
fix: Improve activity presenter transition #1600
0b1beb9
priyonto added a commit that referenced this issue Dec 27, 2023
@priyonto
fix: Improve activity presenter transition #1600 (#1821)
de2fca1
@priyonto priyonto mentioned this issue Dec 27, 2023
Merged
priyonto added a commit that referenced this issue Dec 27, 2023
@priyonto @rinat-enikeev
Enhancements and bug fixes (#1823)
58f145e 
* fix: Fix UI glitch after toast is dismissed #1600 (#1816)

Increase min screen on time for toast to 1.5 seconds from 1 second.

* Add battery level check on FW upgrade from Discover (#1819)

Implements battery charge check on Firmware upgrade process on Discover

* task: Disable RSSI alert editing for local sensors #1751 (#1820)

* fix: View menu not updating after sync from cloud #1632 (#1822)

* fix: Improve activity presenter transition #1600 (#1821)

---------

Co-authored-by: Rinat Enikeev <rinat.enikeev@gmail.com>
@priyonto priyonto assigned markoaamunkajo and unassigned priyonto Dec 27, 2023
@markoaamunkajo
Copy link
Collaborator Author

QA passed

@markoaamunkajo markoaamunkajo removed their assignment Dec 28, 2023
@markoaamunkajo markoaamunkajo reopened this Jan 2, 2024
@markoaamunkajo
Copy link
Collaborator Author

Reopened, I managed to get app freeze by editing and saving description for Cloud Connection alert, then wasn't able to move on the page, app was frozen.

@priyonto priyonto assigned markoaamunkajo and unassigned priyonto Jan 3, 2024
@markoaamunkajo
Copy link
Collaborator Author

QA passed

@markoaamunkajo markoaamunkajo removed their assignment Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4h bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
2.6
Development

No branches or pull requests
3 participants
@laurijamsa @priyonto @markoaamunkajo