Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.5.2 to Alpha #1771

Merged
merged 16 commits into from
Dec 12, 2023
Merged

Release 2.5.2 to Alpha #1771

merged 16 commits into from
Dec 12, 2023

Conversation

rinat-enikeev
Copy link
Contributor

rinat-enikeev and others added 16 commits December 9, 2023 14:54
* Use SwiftGen for localization
Implements extracting localizable strings to framework, utilizing power of swiftgen to generate static enum. Replaces all occurences of String.localized() with enum RuuviLocalization

* fix percent

* remove humidity_relative_unit

* remove outdated method

* remove unused text

* days

* fix token id

* dew symbol

* fix user api errors

* remove localization service
as we dont need localization on the fly
Apply changes made by swift format to the whole app project
Cleans the codebase with auto fixes from SwiftLint
* Eliminate warnings and fix localization
Fixes localization issues related to %0.f

* suppress OTHER_LDFLAGS: -Xlinker -no_warn_duplicate_libraries

* suppress OTHER_LDFLAGS: -Xlinker -no_warn_duplicate_libraries in widgets
fix: Update widget localised string identifiers #1714
* Install swiftlint to .tools subdirectory from Make command
Implements installing swiftlint from make command

* fix swiftlint warnings

* fix last warmning flatMap

* newline at the end

* return in localization
* Add pr_checks GitHub Actions workflow
Implements linter checks on the PR.

* lint whole project

* fix swiftlint artificial violation
fix: Show cloud connection alert for only users with pro+ plans #1750
Removes Pods xcodeworkspace and SPM yml files. Motivation: not used
Motivation: branding. What: renamed frameworks xcodeproj to `Ruuvi`.
feature: Show cloud saving state on sensor settings #1600
Copy link

sonarcloud bot commented Dec 12, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

7.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@rinat-enikeev rinat-enikeev merged commit 6ef949b into alpha Dec 12, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants