-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.5.2 to Alpha #1771
Merged
Merged
Release 2.5.2 to Alpha #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rinat-enikeev
commented
Dec 12, 2023
- Sync status to sensor settings page Sync status to sensor settings page #1600
* Use SwiftGen for localization Implements extracting localizable strings to framework, utilizing power of swiftgen to generate static enum. Replaces all occurences of String.localized() with enum RuuviLocalization * fix percent * remove humidity_relative_unit * remove outdated method * remove unused text * days * fix token id * dew symbol * fix user api errors * remove localization service as we dont need localization on the fly
Apply changes made by swift format to the whole app project
Cleans the codebase with auto fixes from SwiftLint
* Eliminate warnings and fix localization Fixes localization issues related to %0.f * suppress OTHER_LDFLAGS: -Xlinker -no_warn_duplicate_libraries * suppress OTHER_LDFLAGS: -Xlinker -no_warn_duplicate_libraries in widgets
fix: Update widget localised string identifiers #1714
* Install swiftlint to .tools subdirectory from Make command Implements installing swiftlint from make command * fix swiftlint warnings * fix last warmning flatMap * newline at the end * return in localization
to fix warning
* Add pr_checks GitHub Actions workflow Implements linter checks on the PR. * lint whole project * fix swiftlint artificial violation
fix: Show cloud connection alert for only users with pro+ plans #1750
Removes Pods xcodeworkspace and SPM yml files. Motivation: not used
Motivation: branding. What: renamed frameworks xcodeproj to `Ruuvi`.
feature: Show cloud saving state on sensor settings #1600
Quality Gate failedFailed conditions 7.2% Duplication on New Code (required ≤ 3%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.