Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add black github action #17

Merged
merged 5 commits into from
May 4, 2021
Merged

Conversation

JackTemaki
Copy link
Contributor

I added a github action to check for the code formatting, I am not sure if we keep the default settings so I also added a pyproject.toml to configure black if needed.

So open discussion:

  • should we keep the weird default of 88 characters? or do we adjust this to the more common 120?
  • should run black with a specific python version targeted? (If not, it will determine the version based on each file individually)

@curufinwe
Copy link
Contributor

Currently the code is formatted with the default 88 char limit and I dont see large problems.
I'd go for python 3.6 for now. Rational: rwth-i6/returnn#487

@JackTemaki JackTemaki marked this pull request as ready for review May 4, 2021 09:10
@JackTemaki
Copy link
Contributor Author

Okay everything is ready now, I fixed the black version, applied it, and also added a requirements.txt so that the correct version can be easily installed.

@JackTemaki JackTemaki requested a review from curufinwe May 4, 2021 09:28
@curufinwe curufinwe merged commit f445d6c into rwth-i6:main May 4, 2021
curufinwe pushed a commit that referenced this pull request May 4, 2021
@curufinwe
Copy link
Contributor

Messed up original commit, force pushed indended (rebased) version

@JackTemaki JackTemaki deleted the github_actions branch May 6, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants