Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change black formatting to 120 chars? #362

Closed
albertz opened this issue Feb 18, 2023 · 5 comments · Fixed by #367
Closed

Change black formatting to 120 chars? #362

albertz opened this issue Feb 18, 2023 · 5 comments · Fixed by #367

Comments

@albertz
Copy link
Member

albertz commented Feb 18, 2023

This is the default we always had in RETURNN, also in returnn-common, and pretty universal (also default in PyCharm).

Corresponding issue in i6_experiments: rwth-i6/i6_experiments#118
@albertz
Copy link
Member Author

albertz commented Feb 18, 2023

It was briefly mentioned (but not really discussed) here: #17 #5

@albertz albertz mentioned this issue Feb 18, 2023
Closed
@JackTemaki
Copy link
Contributor

@curufinwe @michelwi

I would vote for 120.

@christophmluscher
Copy link
Contributor

120 :)

@michelwi
Copy link
Contributor

sure.. why not.. 🤷

@curufinwe
Copy link
Contributor

No objections from my side.

albertz added a commit that referenced this issue Mar 1, 2023
@albertz
black 120 char line length
028d0ab 
#362
albertz added a commit that referenced this issue Mar 1, 2023
@albertz
black 120 chars reformat
07b9851 
#362
@albertz albertz mentioned this issue Mar 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Black 120 char line length rwth-i6/i6_core
5 participants
@albertz @curufinwe @christophmluscher @JackTemaki @michelwi